CI: cleanup and factorization of molecule tests #12302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
Contributor
Author
|
/label tide/merge-method-merge |
k8s-ci-robot
added
the
tide/merge-method-merge
k8s-ci-robot
added
the
do-not-merge/work-in-progress
VannTen
force-pushed
the
ci/factorize_molecule_scenario
branch
18 times, most recently
from
e89fa6d to
c8745eb
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
|
Can I review this PR? (I am currently removing Ubuntu 20.04 vagrant testing and am encountering issues.) |
Contributor
Author
|
Of course, why couldn't you ?
|
Member
|
/cc |
tico88612
reviewed
Jun 17, 2025
Member
tico88612
left a comment
tico88612
left a comment
There was a problem hiding this comment.
Sorry for the delayed response.
I took some time to review and research it, and removing vagrant and replacing it with kubevirt is a good idea.
However, there are still some minor issues.
- youki and gvisor molecule tests are now passing - kata-containers still broken
VannTen
force-pushed
the
ci/factorize_molecule_scenario
branch
from
c8745eb to
50a32ac
Compare
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tico88612, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Kinda needed for #12299
Does this PR introduce a user-facing change?: