Skip to content

Conversation

@pehlicd
Copy link
Contributor

@pehlicd pehlicd commented Feb 2, 2026

Description

This PR implements automatic DaemonSet toleration injection for readiness.k8s.io/* taints using MutatingAdmissionPolicy with ConfigMap parameter resource and automated sync via the existing controller.

Key features:

  • Zero additional infrastructure (no webhook server needed)
  • ConfigMap-based parameter resource for dynamic toleration data
  • Extended existing RuleReconciler to automatically sync taints → ConfigMap
  • CEL-based mutation logic
  • Opt-out support via annotation

Related Issue

Fixes #7

Type of Change

/kind feature

Testing

Tested in local kind cluster.

Checklist

  • make test passes
  • make lint passes

Does this PR introduce a user-facing change?

Added optional MutatingAdmissionPolicy for automatic DaemonSet toleration injection. When enabled, DaemonSets automatically receive tolerations for all readiness.k8s.io/* taints, ensuring they can schedule on nodes during readiness transitions. Requires Kubernetes 1.32+ with MutatingAdmissionPolicy feature gate enabled.

Doc #7

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 2, 2026
@netlify
Copy link

netlify bot commented Feb 2, 2026

Deploy Preview for node-readiness-controller ready!

Name Link
🔨 Latest commit 24fde7b
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/6980898011d4f3000888af1c
😎 Deploy Preview https://deploy-preview-117--node-readiness-controller.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pehlicd
Once this PR has been reviewed and has the lgtm label, please assign tallclair for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 2, 2026
Signed-off-by: pehlicd <furkanpehlivan34@gmail.com>
@pehlicd pehlicd force-pushed the feat-auto-tolerate-daemonSets-with-map branch from 9676992 to 24fde7b Compare February 2, 2026 11:24
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Auto tolerate DaemonSets with mutating admission controller

2 participants