feat: add evictAfterOOMThreshold per vpa by omerap12 · Pull Request #9071 · kubernetes/autoscaler

omerap12 · 2026-01-18T07:02:41Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

evictAfterOOMThreshold is now per vpa

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[AEP]: https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler/enhancements/8026-per-vpa-component-configuration

omerap12 · 2026-01-18T07:03:39Z

/hold
/kind api-change
/label api-review

soltysh

Initial comments from API shadow

soltysh · 2026-01-29T16:54:33Z

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go

+	// +kubebuilder:validation:Type=string
+	// +kubebuilder:validation:Format=duration
+	// +kubebuilder:validation:Pattern=`^([0-9]+(\.[0-9]+)?(ns|us|µs|ms|s|m|h))+$`
+	EvictAfterOOMThreshold *metav1.Duration `json:"evictAfterOOMThreshold,omitempty" protobuf:"bytes,4,opt,name=evictAfterOOMThreshold"`


I don't think we have any metav1.Duration in the k/k APIs, and from a quick grep it seems we don't have them in this repo. So I'd suggest to stick with the usual units as described here https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#units. Example EvictAfterOOMSeconds or something like that.

I've added noduration to kube-api-linter: #9147

I don't know if this matters, but, this field is an override to the --evict-after-oom-threshold flag, which is currently a duration:

autoscaler/vertical-pod-autoscaler/pkg/updater/priority/update_priority_calculator.go

Lines 41 to 43 in e8fe343

evictAfterOOMThreshold = flag.Duration("evict-after-oom-threshold", 10*time.Minute,

`Evict pod that has OOMed in less than evict-after-oom-threshold since start.`)

)

Keeping the flag and API constant feels like a nice thing to do, but I'm assuming the reason listed in the api-conventions doc is higher priority:

We don't use Duration in the API since that would require clients to implement go-compatible parsing.

Thanks Maciej (again) :)
@adrianmoisey , so let's go with EvictAfterOOMSeconds? I will update the AEP and this PR if that's ok with you.

Keeping the flag and API constant feels like a nice thing to do, but I'm assuming the reason listed in the api-conventions doc is higher priority

Flags have better parsing capabilities and it's exposed only to cluster admins. API is user-facing and this would force clients to support go-compatible parsing rules, it's mentioned in our API conventions.

adrianmoisey · 2026-02-08T08:22:57Z

vertical-pod-autoscaler/pkg/updater/priority/update_priority_calculator.go


+const (
+	// DefaultEvictAfterOOMThreshold is the default time threshold for evicting pods after OOM
+	DefaultEvictAfterOOMThreshold = 10 * time.Minute


Does this need to be public?

Actually, any reason why this moved to a const? Seems like only 1 thing uses it

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go

soltysh

One minor nit, but this lgtm from api-shadow pov

soltysh · 2026-02-12T16:51:10Z

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go

 }

 // PodUpdatePolicy describes the rules on how changes are applied to the pods.
+// +kubebuilder:validation:XValidation:rule="!has(self.evictAfterOOMSeconds) || self.evictAfterOOMSeconds > 0",message="evictAfterOOMSeconds must be greater than 0"


Nit: I don't think you need double validation for > 0. You already have kubebuilder:validation:Minimum=1 set directly on the field.

agreed, let's not add CEL validation that redoes validation we already applied

Fixed. thanks folks :)

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

adrianmoisey · 2026-02-13T14:18:16Z

/approve

k8s-ci-robot · 2026-02-13T14:18:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianmoisey, omerap12, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~vertical-pod-autoscaler/OWNERS~~ [adrianmoisey,omerap12]
~~vertical-pod-autoscaler/pkg/apis/OWNERS~~ [adrianmoisey,omerap12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from adrianmoisey and raywainman January 18, 2026 07:02

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-area labels Jan 18, 2026

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. api-review Categorizes an issue or PR as actively needing an API review. labels Jan 18, 2026

github-project-automation bot added this to API Reviews Jan 18, 2026

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 25, 2026

soltysh moved this to Backlog in API Reviews Jan 29, 2026

soltysh mentioned this pull request Jan 29, 2026

feat: CPU startup boost in master #9141

Open

soltysh reviewed Jan 29, 2026

View reviewed changes

liggitt moved this from Backlog to Changes requested in API Reviews Jan 29, 2026

omerap12 mentioned this pull request Jan 31, 2026

change evictAfterOOMThreshold to evictAfterOOMSeconds using int32 type #9153

Merged

omerap12 force-pushed the evictAfterOOMThreshold branch from 1ddfd7b to cb9dc87 Compare February 4, 2026 11:52

adrianmoisey reviewed Feb 8, 2026

View reviewed changes

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go Outdated Show resolved Hide resolved

omerap12 force-pushed the evictAfterOOMThreshold branch from eb2d515 to e26f744 Compare February 8, 2026 10:02

soltysh approved these changes Feb 12, 2026

View reviewed changes

omerap12 force-pushed the evictAfterOOMThreshold branch 3 times, most recently from c6fff23 to e034392 Compare February 13, 2026 13:38

feat: add evictAfterOOMSeconds per vpa

81fe9f7

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

omerap12 force-pushed the evictAfterOOMThreshold branch from e034392 to 81fe9f7 Compare February 13, 2026 13:40

	evictAfterOOMThreshold = flag.Duration("evict-after-oom-threshold", 10*time.Minute,
	`Evict pod that has OOMed in less than evict-after-oom-threshold since start.`)
	)

Conversation

omerap12 commented Jan 18, 2026

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

omerap12 commented Jan 18, 2026

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soltysh Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adrianmoisey commented Feb 13, 2026

Uh oh!

k8s-ci-robot commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

soltysh Feb 12, 2026 •

edited

Loading