Skip to content

Add -race flag to CA UT script#9160

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
kukichek:add_race_flag_to_ca_tests
Feb 12, 2026
Merged

Add -race flag to CA UT script#9160
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
kukichek:add_race_flag_to_ca_tests

Conversation

@kukichek
Copy link
Contributor

@kukichek kukichek commented Feb 3, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds race check to CA UT script runner

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-area labels Feb 3, 2026
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 3, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @kukichek. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 3, 2026
@kukichek
Copy link
Contributor Author

kukichek commented Feb 3, 2026

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 3, 2026
@adrianmoisey
Copy link
Member

/area cluster-autoscaler

@mboersma
Copy link
Contributor

mboersma commented Feb 3, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2026
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kukichek could you add a superficial change to the CA go source code (e.g., a comment) to trigger a test run?

@kukichek kukichek changed the title Add -race flag to CA UT script WIP Add -race flag to CA UT script Feb 4, 2026
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2026
@kukichek kukichek force-pushed the add_race_flag_to_ca_tests branch from b9b3932 to 8770d8c Compare February 4, 2026 19:06
@kukichek
Copy link
Contributor Author

kukichek commented Feb 4, 2026

@jackfrancis Added a commit with some comment reformatting. The tests are passing

@kgolab
Copy link
Collaborator

kgolab commented Feb 6, 2026

/approve

@kukichek kukichek force-pushed the add_race_flag_to_ca_tests branch from 0e52817 to 78dcb6e Compare February 6, 2026 16:27
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2026
@kukichek
Copy link
Contributor Author

kukichek commented Feb 6, 2026

/retitle Add -race flag to CA UT script

@k8s-ci-robot
Copy link
Contributor

@kukichek: Re-titling can only be requested by trusted users, like repository collaborators.

Details

In response to this:

/retitle Add -race flag to CA UT script

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kgolab kgolab changed the title WIP Add -race flag to CA UT script Add -race flag to CA UT script Feb 9, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2026
@kukichek kukichek force-pushed the add_race_flag_to_ca_tests branch from 78dcb6e to 1f5ac62 Compare February 9, 2026 10:46
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2026
@kukichek kukichek requested a review from jackfrancis February 9, 2026 10:48
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, kgolab, kukichek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2026
@k8s-ci-robot k8s-ci-robot merged commit 111ae64 into kubernetes:master Feb 12, 2026
8 checks passed
@jackfrancis
Copy link
Contributor

/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.33
/cherry-pick cluster-autoscaler-release-1.34
/cherry-pick cluster-autoscaler-release-1.35

@k8s-infra-cherrypick-robot

@jackfrancis: #9160 failed to apply on top of branch "cluster-autoscaler-release-1.32":

Applying: Add -race flag to ca test script
Using index info to reconstruct a base tree...
A	hack/go-unit-tests-ca.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/install-verify-tools.sh
CONFLICT (content): Merge conflict in hack/install-verify-tools.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add -race flag to ca test script

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.33
/cherry-pick cluster-autoscaler-release-1.34
/cherry-pick cluster-autoscaler-release-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jackfrancis
Copy link
Contributor

/cherry-pick cluster-autoscaler-release-1.33

@k8s-infra-cherrypick-robot

@jackfrancis: #9160 failed to apply on top of branch "cluster-autoscaler-release-1.33":

Applying: Add -race flag to ca test script
Using index info to reconstruct a base tree...
A	hack/go-unit-tests-ca.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/install-verify-tools.sh
CONFLICT (content): Merge conflict in hack/install-verify-tools.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add -race flag to ca test script

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.33
/cherry-pick cluster-autoscaler-release-1.34
/cherry-pick cluster-autoscaler-release-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@jackfrancis: #9160 failed to apply on top of branch "cluster-autoscaler-release-1.33":

Applying: Add -race flag to ca test script
Using index info to reconstruct a base tree...
A	hack/go-unit-tests-ca.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/install-verify-tools.sh
CONFLICT (content): Merge conflict in hack/install-verify-tools.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add -race flag to ca test script

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@jackfrancis: #9160 failed to apply on top of branch "cluster-autoscaler-release-1.34":

Applying: Add -race flag to ca test script
Using index info to reconstruct a base tree...
A	hack/go-unit-tests-ca.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/install-verify-tools.sh
CONFLICT (content): Merge conflict in hack/install-verify-tools.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add -race flag to ca test script

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.33
/cherry-pick cluster-autoscaler-release-1.34
/cherry-pick cluster-autoscaler-release-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jackfrancis
Copy link
Contributor

/cherry-pick cluster-autoscaler-release-1.35

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #9225

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.33
/cherry-pick cluster-autoscaler-release-1.34
/cherry-pick cluster-autoscaler-release-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request could not be created: failed to create pull request against kubernetes/autoscaler#cluster-autoscaler-release-1.35 from head k8s-infra-cherrypick-robot:cherry-pick-9160-to-cluster-autoscaler-release-1.35: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-9160-to-cluster-autoscaler-release-1.35."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants