Add -race flag to CA UT script#9160
Conversation
|
Hi @kukichek. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/release-note-none |
|
/area cluster-autoscaler |
|
/ok-to-test |
jackfrancis
left a comment
There was a problem hiding this comment.
@kukichek could you add a superficial change to the CA go source code (e.g., a comment) to trigger a test run?
b9b3932 to
8770d8c
Compare
|
@jackfrancis Added a commit with some comment reformatting. The tests are passing |
|
/approve |
0e52817 to
78dcb6e
Compare
|
/retitle Add -race flag to CA UT script |
|
@kukichek: Re-titling can only be requested by trusted users, like repository collaborators. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
78dcb6e to
1f5ac62
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, kgolab, kukichek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick cluster-autoscaler-release-1.32 |
|
@jackfrancis: #9160 failed to apply on top of branch "cluster-autoscaler-release-1.32": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick cluster-autoscaler-release-1.33 |
|
@jackfrancis: #9160 failed to apply on top of branch "cluster-autoscaler-release-1.33": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jackfrancis: #9160 failed to apply on top of branch "cluster-autoscaler-release-1.33": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jackfrancis: #9160 failed to apply on top of branch "cluster-autoscaler-release-1.34": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick cluster-autoscaler-release-1.35 |
|
@jackfrancis: new pull request created: #9225 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jackfrancis: new pull request could not be created: failed to create pull request against kubernetes/autoscaler#cluster-autoscaler-release-1.35 from head k8s-infra-cherrypick-robot:cherry-pick-9160-to-cluster-autoscaler-release-1.35: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-9160-to-cluster-autoscaler-release-1.35."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds race check to CA UT script runner
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: