Skip to content

Draft: Add performance benchmark for the CA RunOnce control loop #9199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Choraden wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Draft: Add performance benchmark for the CA RunOnce control loop #9199

Choraden wants to merge 5 commits into from
+1,682 −259

Conversation

@Choraden
Copy link
Contributor

@Choraden Choraden commented Feb 9, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

While working on #9022, it became clear that a standardized benchmark is necessary to quantify performance gains and prevent potential regressions in the core logic.

Leveraging the ongoing refactor of the autoscaler building logic in #9099, this PR introduces an initial draft of a benchmark specifically for the RunOnce function. This provides a controlled environment to measure the impact of architectural changes on the main execution loop.

Which issue(s) this PR fixes:

Relates to #9022

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

GaetanoMar96 and others added 5 commits February 3, 2026 15:02
@GaetanoMar96
Refactor main to allow dependency injection
02e1ac6
@GaetanoMar96
Allow synctest usage passing context.
1c02f08
@GaetanoMar96
Add a full cycle CA test.
58e27de
@Choraden
Respect DRA and CSI flags in NewTestProcessors
f47d033 
Update NewTestProcessors to use DynamicResourceAllocationEnabled and
CSINodeAwareSchedulingEnabled from AutoscalingOptions instead of hardcoded values.
This allows tests to properly configure custom resource processing.
@Choraden
Add initial performance benchmark for the RunOnce control loop
7b8f5d6 
Introduce a benchmarking framework for Cluster Autoscaler's primary control loop (RunOnce).
This enables performance regression testing by simulating cluster operations with a mock Kubernetes API and cloud provider.

Also includes enhancements to the fake cloud provider to better track node group state and
provide more flexible configuration options.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 9, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 9, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 9, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 9, 2026

Hi @Choraden. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 9, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Choraden
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from feiskyer February 9, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

No one assigned

Labels

area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Choraden @k8s-ci-robot @GaetanoMar96