Skip to content

Increase delete-collections-workers flag value to speed up namespace deletion#17934

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ronaldngounou:set-delete-collection-worker-flag
Feb 8, 2026
Merged

Increase delete-collections-workers flag value to speed up namespace deletion#17934
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ronaldngounou:set-delete-collection-worker-flag

Conversation

@ronaldngounou
Copy link
Member

@ronaldngounou ronaldngounou commented Feb 7, 2026

Background:

The ec2-master-scale-performance tests were failing due to not meeting DELETE events SLOs.

Root cause

ec2-master-scale-performance had 1.2 Million pre-existing events that needed cleanup, causing cascading performance issues.

AWS scale tests started the test with 1.2Million events to delete. It created a huge backlog of events to clean up by the garbage collector.kubernetes/kubernetes#135737 (comment)

Whereas GCE started the test with 150k events. kubernetes/kubernetes#135737 (comment)

Solution:

Increase --delete-collections-workers flag to 100 (arbitrary value) to accelerate namespace clean up.

Contributes to issue kubernetes/kubernetes#135737

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2026
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 7, 2026
@k8s-ci-robot
Copy link
Contributor

@ronaldngounou: GitHub didn't allow me to assign the following users: hackman.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign hackman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ronaldngounou
Copy link
Member Author

/assign hakman
/assign upodroid

@ronaldngounou ronaldngounou force-pushed the set-delete-collection-worker-flag branch 2 times, most recently from 62f5b4f to 1965092 Compare February 8, 2026 00:14
@ronaldngounou ronaldngounou force-pushed the set-delete-collection-worker-flag branch from 1965092 to bbaefc1 Compare February 8, 2026 00:25
@ronaldngounou
Copy link
Member Author

/test pull-kops-gce-master-scale-performance-100

…deletion

Background:
The ec2-master-scale-performance tests were failing due to DELETE events not meeting SLOs.

Solution:
Increase --delete-collections-workers flag to 100 (arbitrary value) to accelerate namespace
clean up.
Follow up of PR kubernetes#17928

Signed-off-by: ronaldngounou <rngounou@amazon.com>
@ronaldngounou ronaldngounou force-pushed the set-delete-collection-worker-flag branch from bbaefc1 to f5f4a29 Compare February 8, 2026 00:45
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2026
@hakman
Copy link
Member

hakman commented Feb 8, 2026

/override pull-kops-e2e-k8s-aws-amazonvpc

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-amazonvpc

Details

In response to this:

/override pull-kops-e2e-k8s-aws-amazonvpc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ronaldngounou
Copy link
Member Author

/test pull-kops-e2e-k8s-gce-cilium

@k8s-ci-robot k8s-ci-robot merged commit c46ebdf into kubernetes:master Feb 8, 2026
33 of 34 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Feb 8, 2026
@ronaldngounou
Copy link
Member Author

Thank you @hakman for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants