Increase delete-collections-workers flag value to speed up namespace deletion#17934
Conversation
|
@ronaldngounou: GitHub didn't allow me to assign the following users: hackman. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign hakman |
62f5b4f to
1965092
Compare
1965092 to
bbaefc1
Compare
|
/test pull-kops-gce-master-scale-performance-100 |
…deletion Background: The ec2-master-scale-performance tests were failing due to DELETE events not meeting SLOs. Solution: Increase --delete-collections-workers flag to 100 (arbitrary value) to accelerate namespace clean up. Follow up of PR kubernetes#17928 Signed-off-by: ronaldngounou <rngounou@amazon.com>
bbaefc1 to
f5f4a29
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/override pull-kops-e2e-k8s-aws-amazonvpc |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-amazonvpc DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-kops-e2e-k8s-gce-cilium |
|
Thank you @hakman for the review. |
Background:
The ec2-master-scale-performance tests were failing due to not meeting DELETE events SLOs.
Root cause
ec2-master-scale-performance had 1.2 Million pre-existing events that needed cleanup, causing cascading performance issues.
AWS scale tests started the test with 1.2Million events to delete. It created a huge backlog of events to clean up by the garbage collector.kubernetes/kubernetes#135737 (comment)
Whereas GCE started the test with 150k events. kubernetes/kubernetes#135737 (comment)
Solution:
Increase
--delete-collections-workersflag to 100 (arbitrary value) to accelerate namespace clean up.Contributes to issue kubernetes/kubernetes#135737