enable metrics server for scale tests#17938
enable metrics server for scale tests#17938upodroid wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
But metrics server will not tolerate control-plain taint. |
|
I'll fix that in a separate PR today |
|
Could we separate those efforts? No reason to mix metrics server with exec service. |
|
/hold |
|
@upodroid feel free to /unhold when ready. |
|
I have a better approach, metrics server pods needs to be deployed to tolerate control plane taints and bigger resource and I don't want to add that to kops. Instead, I implemented a kubetest1 flag called Once that's merged and shipped, we'll invoke a script that installs metrics-server to suit our use case and run any arbitrary commands before clusterloader2 starts |
|
/approve cancel |
|
/unapprove |
2d58b4e to
f9783ff
Compare
|
New changes are detected. LGTM label has been removed. |
f9783ff to
bd52015
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
bd52015 to
63ba010
Compare
The kubeup scale jobs used to run metrics-server, so we need to run it as well.
@serathius