Skip to content

enable metrics server for scale tests#17938

Open
upodroid wants to merge 1 commit intokubernetes:masterfrom
upodroid:metrics-server
Open

enable metrics server for scale tests#17938
upodroid wants to merge 1 commit intokubernetes:masterfrom
upodroid:metrics-server

Conversation

@upodroid
Copy link
Member

@upodroid upodroid commented Feb 8, 2026

The kubeup scale jobs used to run metrics-server, so we need to run it as well.

@serathius

@k8s-ci-robot k8s-ci-robot requested review from dims and hakman February 8, 2026 12:48
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 8, 2026
@serathius
Copy link

But metrics server will not tolerate control-plain taint.

@upodroid
Copy link
Member Author

upodroid commented Feb 8, 2026

I'll fix that in a separate PR today

@serathius
Copy link

Could we separate those efforts? No reason to mix metrics server with exec service.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 8, 2026
@hakman
Copy link
Member

hakman commented Feb 8, 2026

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2026
@hakman
Copy link
Member

hakman commented Feb 8, 2026

@upodroid feel free to /unhold when ready.

@upodroid
Copy link
Member Author

upodroid commented Feb 8, 2026

I have a better approach, metrics server pods needs to be deployed to tolerate control plane taints and bigger resource and I don't want to add that to kops. Instead, I implemented a kubetest1 flag called pre-test-cmd which behaves like the exec tester in kubetest2 so it should work much better. It also fixed up a few other kops jobs too

kubernetes-sigs/kubetest2#325

Once that's merged and shipped, we'll invoke a script that installs metrics-server to suit our use case and run any arbitrary commands before clusterloader2 starts

@hakman
Copy link
Member

hakman commented Feb 9, 2026

/approve cancel

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2026
@hakman
Copy link
Member

hakman commented Feb 9, 2026

/unapprove

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2026
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2026
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 9, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants