-
Notifications
You must be signed in to change notification settings - Fork 42.4k
Fix kubectl create configmap example #136703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Yosri Barhoumi <med.yosri.brh@gmail.com>
|
|
|
Welcome @yosri-brh! |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @yosri-brh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yosri-brh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
||
| # Create a new config map named my-config from the key=value pairs in the file | ||
| kubectl create configmap my-config --from-file=path/to/bar | ||
| kubectl create configmap my-config --from-env-file=path/to/bar.env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If path/to/bar is a folder, how about this?
| kubectl create configmap my-config --from-env-file=path/to/bar.env | |
| kubectl create configmap my-config --from-file=path/to/bar/example-file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmktfy the comment mentions "key=value pairs in the file" which matches --from-env-file behavior. example 1 already covers the folder case
What type of PR is this?
/kind documentation
What this PR does / why we need it:
example 4 and example 1 are the same but example 4 comment is about key=value from file which needs --from-env-file not --from-file
Which issue(s) this PR is related to:
Fixes kubernetes/website#54270
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: