fix: typos in error message and comments#22493
fix: typos in error message and comments#22493NAM-MAN wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
|
|
Welcome @NAM-MAN! |
|
Hi @NAM-MAN. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
mloskot
left a comment
There was a problem hiding this comment.
Although the changes look good, I'd rephrase the commit/PR subject this way s/in comments/in error message and comments/. The error message is the most important motivation behind the change as it affects the actual UI/UX, while comments are internal triviality.
A side note: AFAIU, this project (and many K8s projects) does not follow the conventional commits, but if it did, then using the fix tag for this PR would have been incorrect.
|
Thanks for the feedback! Updated both the PR title and commit message to clarify that this includes error message fixes, not just comments. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mloskot, NAM-MAN The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
The Windows unit test failure appears unrelated to this typo fix - it's failing due to file locking issues ( Could someone please retrigger the CI or merge if the test flakiness is a known issue? Thank you! |
We've just got all Windows unit tests couple of days ago. Your PR branch seems to be behind the |
|
@mloskot Done! Rebased on the latest master. Thanks for the heads-up about the Windows test fixes! |
Fix typos:
is is→if is/is,an an→an