Fix minikube status exiting with 0 when container doesn't exist

[badal773]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes minikube status incorrectly exiting with code 0 (success) when the Docker container has been deleted but the profile config still exists. This commonly happens when users run docker system prune -a after stopping minikube.

Which issue(s) this PR fixes:

Fixes #22466

Before:

$ minikube stop
$ docker system prune -a
$ minikube status; echo $?
E0116 14:50:53.995077 ... status error: host: state: unknown state "minikube": docker container inspect minikube --format={{.State.Status}}: exit status 1
stderr:
Error response from daemon: No such container: minikube
0   # Incorrectly exits with 0

After:

$ minikube stop  
$ docker system prune -a
$ minikube status; echo $?
E0118 02:19:24.807801 ... the "minikube" host does not exist
E0118 02:19:24.807811 ... status error: the "minikube" host does not exist
7   # Correctly exits with 7 (all components not running)

Changes made:

• Handle "No such container" error in ContainerStatus() by returning state.None without an error
• Update exitCode() to return non-zero (7) when status retrieval fails or returns no statuses
• Add test cases for error and empty status scenarios

Exit code 7 represents all failure flags set: 1 (minikube) | 2 (cluster) | 4 (k8s) = 7

# Build minikube
make out/minikube

# Test 1: Status with deleted container
./out/minikube status; echo "Exit code: $?"

E0118 02:40:21.278493    7532 status.go:183] the "minikube" host does not exist
E0118 02:40:21.278507    7532 status.go:129] status error: the "minikube" host does not exist
Exit code: 7


# Test 3: Unit tests
 go test ./cmd/minikube/cmd/... -run "TestExitCode" -v

=== RUN   TestExitCode
=== RUN   TestExitCode/ok
=== RUN   TestExitCode/paused
=== RUN   TestExitCode/down
=== RUN   TestExitCode/missing
=== RUN   TestExitCode/error
=== RUN   TestExitCode/empty
--- PASS: TestExitCode (0.00s)
    --- PASS: TestExitCode/ok (0.00s)
    --- PASS: TestExitCode/paused (0.00s)
    --- PASS: TestExitCode/down (0.00s)
    --- PASS: TestExitCode/missing (0.00s)
    --- PASS: TestExitCode/error (0.00s)
    --- PASS: TestExitCode/empty (0.00s)
PASS
ok  	k8s.io/minikube/cmd/minikube/cmd	(cached)
testing: warning: no tests to run
PASS
ok  	k8s.io/minikube/cmd/minikube/cmd/config	(cached) [no tests to run]
?   	k8s.io/minikube/cmd/minikube/cmd/flags	[no test files]

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: badal773 / name: Badal Kumar (9d8d9de)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: badal773
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @badal773!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @badal773. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

@badal773 please rebase