UI: make fatal/conflict and failures red color

[medyagh]

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull request overview

Adds support for applying ANSI color codes to stylized console output, enabling red-highlighted warning messages.

Changes:

• Extend style.Options with a Color field to support style-level coloring.
• Add a per-call color override path via out.Color(...) and stylized/applyStyle updates.
• Update minikube start to print the Docker-runtime warning in red.

Reviewed changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/minikube/style/style.go	Adds Color field to style options for default style coloring.
pkg/minikube/out/out_style.go	Adds color application logic and supports per-call override color.
pkg/minikube/out/out.go	Introduces out.Color(...) helper for passing a color override through templating args.
pkg/minikube/out/out_style_test.go	Updates tests for the new applyStyle signature.
cmd/minikube/cmd/start.go	Applies red coloring to a specific runtime warning output.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Options.Color is introduced and applyStyle supports it, but nothing in style.Config sets Color yet (so the branch is effectively dead unless every call uses an override). If the goal is “red warnings”, consider setting style.Config[style.Warning].Color (and similar styles) instead of leaving defaults empty, or remove the field until it’s actually used.

[Copilot]

This call-site uses a per-message color override for a warning. If warnings are intended to be red globally, using the new style.Options.Color for style.Warning would avoid having to thread out.Color(...) through each warning call and keeps styling concerns centralized.

Suggested change

	out.WarningT(`Starting v1.39.0, minikube will default to "containerd" container runtime. See #21973 for more info.`, out.Color(style.Red))
	out.WarningT(`Starting v1.39.0, minikube will default to "containerd" container runtime. See #21973 for more info.`)

[k8s-ci-robot]

@medyagh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
integration-vfkit-docker-macos-arm	49c218b	link	false	/test integration-vfkit-docker-macos-arm
integration-docker-docker-linux-arm	7fc33bb	link	true	/test integration-docker-docker-linux-arm
integration-docker-docker-linux-x86	7fc33bb	link	true	/test integration-docker-docker-linux-x86
integration-kvm-docker-linux-x86	7fc33bb	link	true	/test integration-kvm-docker-linux-x86
integration-docker-crio-linux-x86	7fc33bb	link	false	/test integration-docker-crio-linux-x86
pull-minikube-docker-docker-linux-arm	7fc33bb	link	true	/test pull-minikube-docker-docker-linux-arm
pull-minikube-docker-docker-linux-x86	7fc33bb	link	true	/test pull-minikube-docker-docker-linux-x86

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[k8s-ci-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.