-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Document CSI node ID annotations #54035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-1.36
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
It's actually OK to mark both of these deprecated right away, because the paradigm of putting "alpha" or "beta" in the key is deprecated, and any label or annotation using the old way can be marked deprecated on those grounds. Also we can mark things deprecated even if we don't have a plan to migrate to a different key. The text should briefly explain the situation to readers though; they might wonder what persistent storage to use if non-CSI is deprecated and CSI depends on using a deprecated annotation. I think this is fine though; various important subparts of Kubernetes were technically in alpha at the 1.0 release and were still alpha come (eg) v1.17, and the world Did Not End. |
@lmktfy we can not deprecated the /cc @jsafrane |
01dc368 to
4ad3801
Compare
updated. |
Adds documentation for csi.alpha.kubernetes.io/node-id annotation used on VolumeAttachments for finding node identifiers when CSINode object is unavailable, and csi.volume.kubernetes.io/nodeid deprecated annotation previously used on Nodes. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: carlory <baofa.fan@daocloud.io>
1544bd7 to
e427b89
Compare
Summary
csi.alpha.kubernetes.io/node-idannotation used on VolumeAttachments for finding node identifiers when CSINode object is unavailablecsi.volume.kubernetes.io/nodeiddeprecated annotation previously used on Nodesrelated to kubernetes/kubernetes#135676
🤖 Generated with Claude Code