Skip to content

Fix max-allowable-numa-nodes documentation#54271

Open
komuta wants to merge 1 commit intokubernetes:mainfrom
criteo-forks:fix-max-allowable-numa-nodes-documentation
Open

Fix max-allowable-numa-nodes documentation#54271
komuta wants to merge 1 commit intokubernetes:mainfrom
criteo-forks:fix-max-allowable-numa-nodes-documentation

Conversation

@komuta
Copy link

@komuta komuta commented Feb 2, 2026

The current documentation implies that the value for max-allowable-numa-nodes is a boolean, whereas an integer is actually expected. Adding also a kubelet config example since TopologyManager options are wrapped as string.

See: https://github.com/kubernetes/kubernetes/blob/bb52ae5e24a4eb118460e8feadee86b9f41b4244/pkg/kubelet/cm/topologymanager/policy_options.go#L61

The current documentation implies that the value for `max-allowable-numa-nodes`
is a boolean, whereas an integer is actually expected.
Adding also a kubelet config example since TopologyManager options are wrapped
as string.

See: https://github.com/kubernetes/kubernetes/blob/bb52ae5e24a4eb118460e8feadee86b9f41b4244/pkg/kubelet/cm/topologymanager/policy_options.go#L61
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lmktfy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from bg-chun February 2, 2026 21:23
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 2, 2026
@k8s-ci-robot k8s-ci-robot requested a review from klueska February 2, 2026 21:23
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 2, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: komuta / name: Julien Pepy (9f830bf)

@k8s-ci-robot
Copy link
Contributor

Welcome @komuta!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 2, 2026
@netlify
Copy link

netlify bot commented Feb 2, 2026

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9f830bf
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/698115e513bcf30007f6aed2
😎 Deploy Preview https://deploy-preview-54271--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Caesarsage
Copy link
Contributor

Hello @komuta

Thanks for your contribution, kindly sign the CLA to enable your contribution to be reviewed

@komuta
Copy link
Author

komuta commented Feb 2, 2026

Thanks @Caesarsage, I'll get the CLA signed ASAP (I'm dependent of office hours in CET 😅 ).

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@Caesarsage
Copy link
Contributor

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants