Fix max-allowable-numa-nodes documentation#54271
Fix max-allowable-numa-nodes documentation#54271komuta wants to merge 1 commit intokubernetes:mainfrom
Conversation
The current documentation implies that the value for `max-allowable-numa-nodes` is a boolean, whereas an integer is actually expected. Adding also a kubelet config example since TopologyManager options are wrapped as string. See: https://github.com/kubernetes/kubernetes/blob/bb52ae5e24a4eb118460e8feadee86b9f41b4244/pkg/kubelet/cm/topologymanager/policy_options.go#L61
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
Welcome @komuta! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hello @komuta Thanks for your contribution, kindly sign the CLA to enable your contribution to be reviewed |
|
Thanks @Caesarsage, I'll get the CLA signed ASAP (I'm dependent of office hours in CET 😅 ). |
|
/easycla |
The current documentation implies that the value for
max-allowable-numa-nodesis a boolean, whereas an integer is actually expected. Adding also a kubelet config example since TopologyManager options are wrapped as string.See: https://github.com/kubernetes/kubernetes/blob/bb52ae5e24a4eb118460e8feadee86b9f41b4244/pkg/kubelet/cm/topologymanager/policy_options.go#L61