fix(topology): support unique helm values per worker cluster#86
Open
ani1609 wants to merge 1 commit intokubeslice:masterfrom
Open
fix(topology): support unique helm values per worker cluster#86ani1609 wants to merge 1 commit intokubeslice:masterfrom
ani1609 wants to merge 1 commit intokubeslice:masterfrom
Conversation
Signed-off-by: Ankit Kr Chowdhury <rakesh856100@gmail.com>
acd717d to
cdda734
Compare
Author
|
hey @narmidm, mind taking a quick look at this when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements per-worker helm values feature allowing individual worker clusters to have custom helm chart configurations while maintaining full backward compatibility.
Overview
This enhancement enables users to specify custom helm chart values for individual worker clusters, providing greater flexibility in configuring worker-specific settings while preserving the existing global configuration approach.
Key Changes
Core Implementation
HelmValuesfield toClusterstruct (pkg/internal/bootstrap-configuration.go)CreateWorkerSpecificHelmChart()(pkg/internal/worker.go)Value Merging Behavior
helm_valuesuse global values only (backward compatible)Example Usage
Fixes #68
How Has This Been Tested?
Test cases:
Test configuration:
Checklist:
Does this PR introduce a breaking change?