fix(cli): prevent uninstall timeout by deleting CRDs before controller#91
Open
1012Charan wants to merge 1 commit intokubeslice:masterfrom
Open
fix(cli): prevent uninstall timeout by deleting CRDs before controller#911012Charan wants to merge 1 commit intokubeslice:masterfrom
1012Charan wants to merge 1 commit intokubeslice:masterfrom
Conversation
Author
|
@narmidm kindly review this |
|
@1012Charan can you please add DCO to your commit. |
Previously, uninstall would fail with 'timed out waiting for the condition' because the controller was removed before workers stopped using it. This change: - Deletes KubeSlice CRDs before removing the controller - Waits 2 seconds for cleanup - Adds timeout flag to helm uninstall for reliability Fixes kubeslice#58 Signed-off-by: 1012Charan <charanvengala@gmail.com>
Author
|
hey @Arpit529Srivastava, I've included DCO as you mentioned. Appreciate your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the timeout issue that occurs during KubeSlice uninstallation. When users run kubeslice-cli uninstall -c, the process would get stuck and fail with a "timed out waiting for the condition" error.
Why was it happening?
The uninstall process was trying to delete the controller first, but the controller couldn't be deleted because workers were still using it. It's like trying to delete a folder while some programs are still using files inside it.
Solution
The fix changes the uninstall order to be smarter:
Changes Made
deleteKubeSliceCRDs()function to delete KubeSlice CRDsUninstallKubeSliceController()to delete CRDs before controller--timeoutparameter to helm uninstall commandFixes #58
How Has This Been Tested?
Test Cases:
kubeslice-cli uninstall -c topology.yaml- should complete successfully without timeoutTest Instructions:
kubeslice-cli install -c topology.yamlkubeslice-cli uninstall -c topology.yamlChecklist:
Does this PR introduce a breaking change?
No, this is a bug fix that makes the uninstall process more reliable. The same command works the same way, just without the timeout issue.