-
Notifications
You must be signed in to change notification settings - Fork 305
Adjust test helper-images push according to arch compatibility #3883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
5a1ce8a to
4aea4c1
Compare
4aea4c1 to
67fa95f
Compare
67fa95f to
9a9219d
Compare
9a9219d to
487fc7d
Compare
|
/test pull-containerized-data-importer-e2e-hpp-latest |
fd24749 to
e971db9
Compare
|
/retest |
|
/cc @akalenyu |
e971db9 to
01ef6fd
Compare
|
A few unsupported images were pushed for arm/s390x, so I added a filter |
The test images weren't pushed correctly, so I'd basically just push them in the same manner as the operators. Signed-off-by: Thomas-David Griedel griedel911@gmail.com
01ef6fd to
65b3882
Compare
|
For Validation: |
|
Found a bug where |
Signed-off-by: Thomas-David Griedel griedel911@gmail.com
I think the cdi repos are private, can't tell if this worked |
8b32e86 to
baa1c85
Compare
|
@akalenyu So I only had a small adjustment to the architectural support to offer here, but I could also open up a new PR for this. |
|
/retest |
akalenyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind if we pivot the existing PR just make sure to adjust commits/pr desc
Oh you're right, thanks for checking! |
Signed-off-by: Thomas-David Griedel griedel911@gmail.com
baa1c85 to
1c80fa1
Compare
Will you be adjusting the title? otherwise the merge commit is going to look off |
What this PR does / why we need it:
The test images weren't manifested correctly, so this pushes them in the same manner as the operators.Push logic now filters per-image supported architectures to avoid publishing broken manifests.
Adds per-image Bazel
container_push targets.Just adjusting which helper image is pushed for what arch.
cdi-func-test-cirros-qcow2is fine for all, whilevcenter-simulatoris only for x86.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3688
Special notes for your reviewer:
Release note: