Skip to content

Conversation

@Davo911
Copy link
Member

@Davo911 Davo911 commented Aug 26, 2025

What this PR does / why we need it:
The test images weren't manifested correctly, so this pushes them in the same manner as the operators.
Push logic now filters per-image supported architectures to avoid publishing broken manifests.
Adds per-image Bazel container_push targets.

Just adjusting which helper image is pushed for what arch.
cdi-func-test-cirros-qcow2 is fine for all, while vcenter-simulator is only for x86.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3688

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 26, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign awels for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Davo911 Davo911 changed the title push test images as operator images Publish test images in a multiarch manifest Aug 26, 2025
@Davo911 Davo911 force-pushed the test-image-multiarch-manifest branch from 5a1ce8a to 4aea4c1 Compare October 17, 2025 00:42
@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 17, 2025
@Davo911 Davo911 marked this pull request as ready for review October 17, 2025 00:43
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2025
@Davo911 Davo911 force-pushed the test-image-multiarch-manifest branch from 4aea4c1 to 67fa95f Compare October 17, 2025 00:43
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Oct 17, 2025
@coveralls
Copy link

coveralls commented Oct 17, 2025

Coverage Status

coverage: 58.782% (-0.3%) from 59.076%
when pulling 77e568a on Davo911:test-image-multiarch-manifest
into 4c3dc65 on kubevirt:main.

@Davo911 Davo911 force-pushed the test-image-multiarch-manifest branch from 67fa95f to 9a9219d Compare October 19, 2025 20:17
@Davo911 Davo911 force-pushed the test-image-multiarch-manifest branch from 9a9219d to 487fc7d Compare October 27, 2025 12:52
@Davo911
Copy link
Member Author

Davo911 commented Oct 28, 2025

/test pull-containerized-data-importer-e2e-hpp-latest

@Davo911 Davo911 force-pushed the test-image-multiarch-manifest branch 2 times, most recently from fd24749 to e971db9 Compare October 30, 2025 12:15
@Davo911
Copy link
Member Author

Davo911 commented Oct 30, 2025

/retest

@Davo911
Copy link
Member Author

Davo911 commented Oct 31, 2025

/cc @akalenyu

@kubevirt-bot kubevirt-bot requested a review from akalenyu October 31, 2025 14:26
@Davo911 Davo911 force-pushed the test-image-multiarch-manifest branch from e971db9 to 01ef6fd Compare November 3, 2025 10:17
@Davo911
Copy link
Member Author

Davo911 commented Nov 3, 2025

A few unsupported images were pushed for arm/s390x, so I added a filter

The test images weren't pushed correctly, so I'd basically just push them in the same manner as the operators.

Signed-off-by: Thomas-David Griedel griedel911@gmail.com
@Davo911 Davo911 force-pushed the test-image-multiarch-manifest branch from 01ef6fd to 65b3882 Compare November 3, 2025 10:32
@Davo911
Copy link
Member Author

Davo911 commented Nov 5, 2025

For Validation:
https://quay.io/user/tgriedel/

@Davo911
Copy link
Member Author

Davo911 commented Nov 8, 2025

Found a bug where cdi-func-test-cirros-qcow2 images are published for all arches but only amd64 is included in the manifest

Signed-off-by: Thomas-David Griedel griedel911@gmail.com
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2025
@kubevirt-bot kubevirt-bot added size/M and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L labels Jan 26, 2026
@akalenyu
Copy link
Collaborator

For Validation: https://quay.io/user/tgriedel/

I think the cdi repos are private, can't tell if this worked

@Davo911 Davo911 force-pushed the test-image-multiarch-manifest branch from 8b32e86 to baa1c85 Compare January 27, 2026 01:08
@Davo911
Copy link
Member Author

Davo911 commented Jan 27, 2026

@akalenyu
looked into this, seems like this issue was solved by another PR when transitioning to rules_oci

So I only had a small adjustment to the architectural support to offer here, but I could also open up a new PR for this.
--> vcenter is not supported for s390x, while the cirros-qcow is working for all arches

@Davo911
Copy link
Member Author

Davo911 commented Jan 27, 2026

/retest

Copy link
Collaborator

@akalenyu akalenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind if we pivot the existing PR just make sure to adjust commits/pr desc

@akalenyu
Copy link
Collaborator

@akalenyu looked into this, seems like this issue was solved by another PR when transitioning to rules_oci

So I only had a small adjustment to the architectural support to offer here, but I could also open up a new PR for this. --> vcenter is not supported for s390x, while the cirros-qcow is working for all arches

Oh you're right, thanks for checking!

Signed-off-by: Thomas-David Griedel griedel911@gmail.com
@Davo911 Davo911 force-pushed the test-image-multiarch-manifest branch from baa1c85 to 1c80fa1 Compare January 27, 2026 17:21
@akalenyu
Copy link
Collaborator

I don't mind if we pivot the existing PR just make sure to adjust commits/pr desc

Will you be adjusting the title? otherwise the merge commit is going to look off

@Davo911 Davo911 changed the title Publish test images in a multiarch manifest Adjust test-image push according to arch compatibility Feb 1, 2026
@Davo911 Davo911 changed the title Adjust test-image push according to arch compatibility Adjust test helper-images push according to arch compatibility Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test images only get published with "version-arch" tags upon releases

4 participants