-
Notifications
You must be signed in to change notification settings - Fork 305
RWX Capability for HPP Overlay #4032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| } | ||
|
|
||
| var storageClassToProvisionerKeyMapper = map[string]func(sc *storagev1.StorageClass) string{ | ||
| "kubevirt.io.hostpath-provisioner": func(sc *storagev1.StorageClass) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both kubevirt.io.hostpath-provisioner and kubevirt.io/hostpath-provisioner existing is a hazard 😆 especially when you used the latter for the overlay provisioner string
maybe extract to variables and use those? HppNonCSI vs HPPCSI? this would minimize the chance for a mixup to like 0.001
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah geez great catch, my eyes must be failing me... just fixed this to only parse the new param from the CSI variant. I don't think we need to account for legacy hpp here
350327b to
dad7f67
Compare
| "kubevirt.io.hostpath-provisioner": {{rwo, file}}, | ||
| "kubevirt.io/hostpath-provisioner": {{rwo, file}}, | ||
| "k8s.io/minikube-hostpath": {{rwo, file}}, | ||
| "kubevirt.io.hostpath-provisioner": {{rwo, file}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be able to swap a few strings like this one with ProvisionerHPPCSI
…ded to be used as an overlay csi class for backend storage Signed-off-by: dsanatar <dsanatar@redhat.com>
dad7f67 to
13a4b0a
Compare
|
@Dsanatar: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
To enable new HPP Overlay support for backend storage PVCs (kubevirt/hostpath-provisioner#483
kubevirt/hostpath-provisioner-operator#653), we need to allow for HPP to provision volumes with RWX access mode. When creating storageprofiles for HPP, add new check for param to determine if HPP Overlay is enabled
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: