Skip to content

Conversation

@Dsanatar
Copy link
Collaborator

@Dsanatar Dsanatar commented Feb 6, 2026

To enable new HPP Overlay support for backend storage PVCs (kubevirt/hostpath-provisioner#483
kubevirt/hostpath-provisioner-operator#653), we need to allow for HPP to provision volumes with RWX access mode. When creating storageprofiles for HPP, add new check for param to determine if HPP Overlay is enabled

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

RWX Capability for HPP Overlay 

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 6, 2026
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign awels for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Feb 6, 2026

Coverage Status

coverage: 49.489% (-0.001%) from 49.49%
when pulling 13a4b0a on Dsanatar:hpp-overlay-csi
into 80b9c60 on kubevirt:main.

}

var storageClassToProvisionerKeyMapper = map[string]func(sc *storagev1.StorageClass) string{
"kubevirt.io.hostpath-provisioner": func(sc *storagev1.StorageClass) string {
Copy link
Collaborator

@akalenyu akalenyu Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both kubevirt.io.hostpath-provisioner and kubevirt.io/hostpath-provisioner existing is a hazard 😆 especially when you used the latter for the overlay provisioner string

maybe extract to variables and use those? HppNonCSI vs HPPCSI? this would minimize the chance for a mixup to like 0.001

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah geez great catch, my eyes must be failing me... just fixed this to only parse the new param from the CSI variant. I don't think we need to account for legacy hpp here

"kubevirt.io.hostpath-provisioner": {{rwo, file}},
"kubevirt.io/hostpath-provisioner": {{rwo, file}},
"k8s.io/minikube-hostpath": {{rwo, file}},
"kubevirt.io.hostpath-provisioner": {{rwo, file}},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be able to swap a few strings like this one with ProvisionerHPPCSI

…ded to be used as an overlay csi class for backend storage

Signed-off-by: dsanatar <dsanatar@redhat.com>
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Feb 9, 2026

@Dsanatar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-containerized-data-importer-fossa 13a4b0a link true /test pull-containerized-data-importer-fossa
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants