Skip to content

chore(deps): update node.js to v22.22.0 #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update node.js to v22.22.0 #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion images/node-rbenv/node-22/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# ====================================================== VERSIONS ======================================================

# renovate: datasource=github-releases depName=node/node versioning=loose
ARG NODE_VERSION=22.20.0
ARG NODE_VERSION=22.22.0
Copy link

@sentry sentry bot Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The PR incompletely updates the Node.js version for node-22 images, missing the -slim variants and the test expectations, which will cause CI tests to fail.
Severity: CRITICAL

Suggested Fix

Update the NODE_VERSION argument to 22.22.0 in images/node-rbenv/node-22-slim/Dockerfile and its ruby-3 sub-variant. Additionally, update the hardcoded version strings in the test file test/prepare-matrix.test.js to expect tags generated from version 22.22.0 for all node-22 images.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: images/node-rbenv/node-22/Dockerfile#L6

Potential issue: The pull request updates the `NODE_VERSION` in the standard `node-22`
Dockerfiles to `22.22.0` but does not update the `node-22-slim` variants, which remain
at `22.20.0`. Furthermore, the associated test file, `test/prepare-matrix.test.js`, is
not updated and still expects tags for version `22.20.0` for all variants. Because the
tag generation script reads the version dynamically from the Dockerfiles, it will
generate `22.22.0` tags for the standard images, causing a mismatch with the hardcoded
test expectations and leading to a CI test failure.

Did we get this right? 👍 / 👎 to inform future reviews.


# ====================================================== PRODUCT =======================================================

Expand Down
2 changes: 1 addition & 1 deletion images/node-rbenv/node-22/ruby-3/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# ====================================================== VERSIONS ======================================================

# renovate: datasource=github-releases depName=node/node versioning=loose
ARG NODE_VERSION=22.20.0
ARG NODE_VERSION=22.22.0
# renovate: datasource=github-releases depName=ruby/ruby versioning=loose
ARG RUBY_VERSION=3.4.5

Expand Down
Loading