Conversation
Removes the redundant transform parameter from bounding rect methods, enabling direct computation of local coordinates. Also updates comments to reflect the new logic.
Clarifies that Rects are now returned in the text object's local space. Highlights breaking changes from versions prior to 0.6.0.
Updates version reference to v0.6.0 for package installation. Adds coordinate system and breaking change notices to README, highlighting the change from Canvas to text object local space.
Updates package metadata for the next release cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces breaking changes to unify the coordinate system for TMP_Text rects, ensuring returned Rect values are consistently in the local space of the text object's transform. Simplifies the rect computation logic by removing transform dependency for point calculation.
Update implementations accordingly as the rects for TMP_Text objects now share the same local coordinate system.