Skip to content

fix(BA-4280): Prevent scoped_query from overriding project param with group_id#8628

Merged
HyeockJinKim merged 3 commits intomainfrom
BA-4280
Feb 7, 2026
Merged

fix(BA-4280): Prevent scoped_query from overriding project param with group_id#8628
HyeockJinKim merged 3 commits intomainfrom
BA-4280

Conversation

@jopemachine
Copy link
Member

@jopemachine jopemachine commented Feb 6, 2026

resolves (BA-4280)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@github-actions github-actions bot added size:XS ~10 LoC comp:manager Related to Manager component labels Feb 6, 2026
@github-actions github-actions bot added size:M 30~100 LoC and removed size:XS ~10 LoC labels Feb 6, 2026
@jopemachine jopemachine added this to the 25.6 milestone Feb 6, 2026
@jopemachine jopemachine marked this pull request as ready for review February 6, 2026 07:15
Copilot AI review requested due to automatic review settings February 6, 2026 07:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a bug in the scoped_query decorator where the project parameter was being silently overridden by the group_id parameter. The fix removes two problematic lines that were unconditionally replacing project with group_id when both parameters were present.

Changes:

  • Removed buggy code in scoped_query that overwrote the project parameter with group_id
  • Added regression test to ensure project and group_id parameters remain distinct
  • Added changelog entry documenting the fix

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/ai/backend/manager/api/gql_legacy/base.py Removes two lines that incorrectly overwrote project parameter with group_id
tests/unit/manager/api/test_gql_legacy_scoped_query.py Adds regression test verifying project parameter is preserved when both project and group_id are provided
changes/8628.fix.md Changelog entry documenting the bug fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HyeockJinKim HyeockJinKim added this pull request to the merge queue Feb 7, 2026
Merged via the queue into main with commit 33d77f4 Feb 7, 2026
41 checks passed
@HyeockJinKim HyeockJinKim deleted the BA-4280 branch February 7, 2026 07:22
lablup-octodog pushed a commit that referenced this pull request Feb 7, 2026
…with `group_id` (#8628)

Backported-from: main (26.1)
Backported-to: 26.1
Backport-of: 8628
@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Backport to 25.15 is failed. Please backport manually.

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Backport to 25.6 is failed. Please backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:manager Related to Manager component size:M 30~100 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants