fix(BA-4280): Prevent scoped_query from overriding project param with group_id#8628
Merged
HyeockJinKim merged 3 commits intomainfrom Feb 7, 2026
Merged
fix(BA-4280): Prevent scoped_query from overriding project param with group_id#8628HyeockJinKim merged 3 commits intomainfrom
scoped_query from overriding project param with group_id#8628HyeockJinKim merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in the scoped_query decorator where the project parameter was being silently overridden by the group_id parameter. The fix removes two problematic lines that were unconditionally replacing project with group_id when both parameters were present.
Changes:
- Removed buggy code in
scoped_querythat overwrote theprojectparameter withgroup_id - Added regression test to ensure
projectandgroup_idparameters remain distinct - Added changelog entry documenting the fix
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/ai/backend/manager/api/gql_legacy/base.py |
Removes two lines that incorrectly overwrote project parameter with group_id |
tests/unit/manager/api/test_gql_legacy_scoped_query.py |
Adds regression test verifying project parameter is preserved when both project and group_id are provided |
changes/8628.fix.md |
Changelog entry documenting the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HyeockJinKim
approved these changes
Feb 7, 2026
lablup-octodog
pushed a commit
that referenced
this pull request
Feb 7, 2026
…with `group_id` (#8628) Backported-from: main (26.1) Backported-to: 26.1 Backport-of: 8628
|
Backport to 25.15 is failed. Please backport manually. |
|
Backport to 25.6 is failed. Please backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves (BA-4280)
Checklist: (if applicable)
ai.backend.testdocsdirectory