[pull] main from open-telemetry:main#627
Merged
pull[bot] merged 2 commits intolalitb:mainfrom Dec 9, 2025
Merged
Conversation
…s to restore C++20 aggregate initialization support (#3780) * Initial plan * Fix BatchSpanProcessorOptions to restore C++20 aggregate initialization support - Remove user-defined constructor that prevented C++20 designated initializers - Add inline helper functions in batch_span_processor_options_env namespace - Use default member initializers calling the helper functions - Update tests with corrected default values (2048 for max_queue_size, 30000ms for export_timeout) - Add test for aggregate initialization and C++20 designated initializers Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com> * Update PR progress Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com> * Remove accidentally committed CodeQL build artifacts and update .gitignore Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com> * Fix C++14 compatibility: remove inline variables from header Move constants inside inline functions to avoid using inline variables which are a C++17 feature not available in C++14. Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com> * Fix Windows DLL compatibility: move helper functions to .cc files - Move env helper function implementations from header to .cc files - Declare helper functions with OPENTELEMETRY_EXPORT in header - Apply the same pattern to BatchLogRecordProcessorOptions - Add comprehensive documentation to both options structs - Fix "to to" typo in BatchSpanProcessorOptions documentation This fixes the Windows single DLL build issue by avoiding inline functions in header files that are called from default member initializers. Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )