changes

[lalitb]

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

• CHANGELOG.md updated for non-trivial changes
• Unit tests have been added
• Changes in public API reviewed

Summary by CodeRabbit

• Chores
  • Improved compilation diagnostic handling and localized warning management to reduce unwanted build noise across platforms.
  • Added CI verification and an automated Windows check to ensure deprecation behavior for event/logging APIs is enforced during builds.

[coderabbitai]

📝 Walkthrough

Walkthrough

Removed GCC/Clang/Apple diagnostic push/pop pragmas that suppressed deprecated-declarations in logging headers, introduced localized MSVC-only warning(suppress : 4996) usages in provider calls, and added a Windows CI step plus PowerShell script to verify MSVC deprecation-as-error behavior for EventLogger APIs.

Changes

Cohort / File(s)	Summary
Header pragma removals api/include/opentelemetry/logs/event_logger.h, api/include/opentelemetry/logs/event_logger_provider.h	Deleted compiler-specific diagnostic push/ignore and pop blocks that previously suppressed deprecated-declarations for GCC/Clang/Apple. No API/signature changes.
Localized MSVC suppressions api/include/opentelemetry/logs/provider.h	Removed broader ABI<2 diagnostic blocks; added per-call #pragma warning(suppress : 4996) before the GetEventLoggerProvider return and before the assignment in SetEventLoggerProvider.
Windows CI check .github/workflows/ci.yml, ci/check_windows_event_api_deprecation.ps1	Added workflow step to run a new PowerShell script that generates a small CMake project and verifies GetLoggerProvider builds while GetEventLoggerProvider fails under MSVC /we4996, scanning build output for C4996.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I hopped through pragmas, nibbling warnings light,

Scoped a tiny silence, kept the meadow bright.
A Windows watch checks every timid peep,
So deprecated echoes tumble into sleep.
Thump-thump — tidy hops, and everything's right.

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is entirely a template placeholder with no actual content describing the changes, making it impossible to understand the PR's purpose.	Fill in the 'Changes' section with a clear explanation of the deprecation warning handling modifications across multiple files and the intent behind moving from pragma blocks to inline suppressions.
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'changes' is vague and generic, providing no meaningful information about what was actually modified in the pull request.	Replace with a specific, descriptive title that summarizes the main change, such as 'Refactor compiler warning suppression for deprecated event logger API' or 'Move MSVC deprecation warnings from pragmas to inline suppressions'.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch event-warning-suppress

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}