Skip to content

Comments

Fix creation of new release branch when new major branch exists#255

Draft
Xerkus wants to merge 2 commits intolaminas:1.25.xfrom
Xerkus:fix/switch-default-branch-from-same-major
Draft

Fix creation of new release branch when new major branch exists#255
Xerkus wants to merge 2 commits intolaminas:1.25.xfrom
Xerkus:fix/switch-default-branch-from-same-major

Conversation

@Xerkus
Copy link
Member

@Xerkus Xerkus commented Feb 2, 2024

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA /no

Description

Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
@Xerkus Xerkus added the Bug Something isn't working label Feb 2, 2024
| 1.2.x |
| 1.3.x |
| 2.0.x |
And branch "1.3.x" should branch from "1.2.x"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition is currently violated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this isn't run, right now, BTW - @manually-tested above

We'd need to unit test this, probably, or add automation (which I was too lazy to do -.- my bad), since these .feature cases only act as documentation.

Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fatal: not a valid object name: '4.0.x' New majors prevent branch creation/switching

2 participants