Prevent multiline matrix payload from causing issues in GitHub workflow output#190
Merged
Ocramius merged 3 commits intolaminas:1.23.xfrom Feb 22, 2023
Merged
Conversation
…ow output Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
force-pushed
the
multiline-output-fix
branch
from
26c0bb3 to
aa1fd30
Compare
Signed-off-by: George Steel <george@net-glue.co.uk>
| # The project name from the tests/ directory is then re-used within the "qa" job to run the generated "container" | ||
| # within that directory. | ||
| run: cd tests; echo "matrix=[\"$(ls -d * | tr '\n' ' ' | sed 's/ $//' | sed 's/ /\",\"/g')\"]" >> $GITHUB_OUTPUT | ||
| run: | |
Member
There was a problem hiding this comment.
Is this needed ASWELL as pinning the version of jq-action? I would hope this change would be all that's needed?
Member
Author
There was a problem hiding this comment.
I don't think so - But, if there's any chance that matrix is multiline, at least the case is covered. It should probably always have been like this WRT #150
We may be able to stick with jq-action@v2 if the multiline option works out for us.
Member
There was a problem hiding this comment.
I think this change needs reverting as "matrix=[\"$(ls -d * | tr '\n' ' ' | sed 's/ $//' | sed 's/ /\",\"/g')\"]" should be on a single line.
Member
Author
There was a problem hiding this comment.
I'll send in another patch @internalsystemerror for 1.23
Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes CI green.
It appears that sergeysova/jq-action@v2.3.0 was at fault here, and enabling its
multilineoption solves the issue.This patch also updates usage of
$GITHUB_OUTPUTincontinuous-integration.ymlin case the matrix generated there is also multiline.Deprecations are still being issued about
set-outputbut I'm not sure where these are coming from 🤷♂️