Verify BC breakages on pull requests, by comparing PR against base branch#226
Merged
boesing merged 9 commits intolaminas:1.23.xfrom Jul 11, 2023
Merged
Conversation
boesing
force-pushed
the
feature/roave-bc-checker
branch
from
c1031f4 to
e1391fa
Compare
Ocramius
approved these changes
Jul 10, 2023
boesing
force-pushed
the
feature/roave-bc-checker
branch
from
95cd090 to
9b5e175
Compare
…E_REF` environment variable This also introduces a new tool type `ToolRunningContainerDefaultPhpVersion`. This is used in case tools are pre-installed within the CI container as it is the case for `roave-backward-compatibility-check`. By having an option available for `backwardCompatibilityCheck`, projects can opt-in for these kind of checks. This flag will be enabled by-default with v2 and thus changes to opt-out. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
This also adds a dedicated test for detecting the target reference from environment using `dotenv` Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
…mport Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
…-ci.schema.json` Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
feature/roave-bc-checker
branch
from
9b5e175 to
ef9f76f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR continues the work of #126 while adapting some changes to reduce complexity:
GITHUB_BASE_REFenvironment variable insteadToolRunningContainerDefaultPhpVersionwhich targets tools which are pre-installed within the CI container (such asroave-backward-compatibility-check), it provides@defaultviaphpjob configuration and thus, the CI container won't change the PHP version which is the default by the moment of executing the container (needs Introduceroave/backward-compatibility-checkand@defaultphp version laminas-continuous-integration-action#158)backwardCompatibilityCheckto opt-in for theroave-backward-compatibility-check, with v2 of the CI pipeline, this flag might be changed to be enabled by-default and projects need to opt-out for it@Xerkus @internalsystemerror I've added you guys as you gave feedback in the initial #126 PR.
@Ocramius I hope its okay that I create a dedicated PR and supersede #126 as I am unable to push to your fork.