Skip to content

Comments

Synchronize package.json and package-lock.json with Dockerfile version of node#298

Merged
boesing merged 3 commits intolaminas:1.25.xfrom
boesing:qa/synchronize-package-json-with-dockerfile
Apr 24, 2024
Merged

Synchronize package.json and package-lock.json with Dockerfile version of node#298
boesing merged 3 commits intolaminas:1.25.xfrom
boesing:qa/synchronize-package-json-with-dockerfile

Conversation

@boesing
Copy link
Member

@boesing boesing commented Apr 24, 2024

Q A
QA yes

Description

The Dockerfile got updated in #285 but the package.json and package-lock.json were not updated.

@boesing boesing added this to the 1.25.0 milestone Apr 24, 2024
@boesing boesing force-pushed the qa/synchronize-package-json-with-dockerfile branch 2 times, most recently from a9c7d18 to 729b121 Compare April 24, 2024 00:40
…-artifact-4.x

Update actions/download-artifact and actions/upload-artifact action to v4
@boesing boesing force-pushed the qa/synchronize-package-json-with-dockerfile branch from 729b121 to bf9f170 Compare April 24, 2024 00:42
…ock-up-to-date`

That new job uses `package-lock-utd` package to verify `package-lock.json` is up2date with what `package.json` requires.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing force-pushed the qa/synchronize-package-json-with-dockerfile branch from ef1e1f9 to 7961bb3 Compare April 24, 2024 00:53
@boesing
Copy link
Member Author

boesing commented Apr 24, 2024

Hm, still have to verify that both node version of Dockerfile is in sync. I've checked some stuff and it felt better to have a generic package-lock.json check but this will still not prevent Dockerfile from diverging from package.json if that is never updated...

WIll have another look tomorrow, its too late now...

… `package.json` engine version range

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing merged commit f25365c into laminas:1.25.x Apr 24, 2024
@boesing boesing deleted the qa/synchronize-package-json-with-dockerfile branch April 24, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant