Skip to content

Comments

feature: php-cs-fixer with checkstyle output forwarded to github pull request#331

Merged
boesing merged 2 commits intolaminas:1.29.xfrom
boesing:feature/php-cs-fixer-checkstyle
Jan 17, 2025
Merged

feature: php-cs-fixer with checkstyle output forwarded to github pull request#331
boesing merged 2 commits intolaminas:1.29.xfrom
boesing:feature/php-cs-fixer-checkstyle

Conversation

@boesing
Copy link
Member

@boesing boesing commented Jan 17, 2025

Q A
New Feature yes

Description

As requested in #320, run php-cs-fixer with --format=checkstyle so that we can pipe it to cs2pr.

closes #320

We do want to have `php-cs-fixer` reporting to github pull requests.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
This reports actual check output to github pull requests for integrated review.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing changed the title feature: php-cs-fixer with checkstyle output forwarded to github pull request feature: php-cs-fixer with checkstyle output forwarded to github pull request Jan 17, 2025
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@froschdesign
Copy link
Member

@boesing boesing added this to the 1.29.0 milestone Jan 17, 2025
@boesing boesing merged commit 60b7e8c into laminas:1.29.x Jan 17, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide checkstyle output for php-cs-fixer with cs2pr

2 participants