Merged
Conversation
Required removal of [eslint-config-incredible](https://github.com/pustovitDmytro/eslint-config-incredible) during upgrade to eslint v9 Adds a simple Makefile to make it easier to muck about with JS deps via docker - Closes laminas#337 - Closes laminas#336 - Closes laminas#335 - Closes laminas#334 - Closes laminas#329 - Closes laminas#309 - Closes laminas#308 - Closes laminas#300 - Closes laminas#296 Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
approved these changes
Oct 16, 2025
Makefile
Outdated
| @@ -0,0 +1,22 @@ | |||
|
|
|||
| NODE_IMG=node:24.10.0-alpine | |||
Member
There was a problem hiding this comment.
Perhaps we should reference a base layer in our Dockerfile, so this is always in sync?
Member
There was a problem hiding this comment.
Would meet to build+tag an image with --target=, then use that tag to run the remaining steps
Member
Author
There was a problem hiding this comment.
I think I understand - I've adjusted Makefile to build and tag the image locally, but docker build --target=compiler just builds everything anyway - not too familiar with multi-stage builds. At least what I've done will stop node versions drifting apart
Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required removal of eslint-config-incredible during upgrade to eslint v9
Adds a simple Makefile to make it easier to muck about with JS deps via docker