chore: support laminas service manager v4#132
Merged
gsteel merged 14 commits intolaminas:5.0.xfrom Jul 8, 2025
Merged
Conversation
gsteel
requested changes
Jul 7, 2025
Member
gsteel
left a comment
gsteel
left a comment
There was a problem hiding this comment.
Thanks @mairo744
Please can you rebase with a sign-off (See instructions in the DCO check failure).
This will have to be released in the next major (5.0.0), so we'll need to come up with a list of other improvements to be done in future patches
mairo744
force-pushed
the
chore/laminas-sm-v4
branch
from
fc41489 to
b6ac096
Compare
gsteel
reviewed
Jul 7, 2025
mairo744
force-pushed
the
chore/laminas-sm-v4
branch
2 times, most recently
from
1e15af4 to
1ffa02e
Compare
Signed-off-by: mmalac <mmalac@sygic.com>
mark as final Co-authored-by: George Steel <george@netglue.uk> Signed-off-by: mairo744 <mairo744@gmail.com> Signed-off-by: mmalac <mmalac@sygic.com>
…orPluginManager was marked as final Signed-off-by: mmalac <mmalac@sygic.com>
… in private constant Signed-off-by: mmalac <mmalac@sygic.com>
…ger as required dependencies Signed-off-by: mmalac <mmalac@sygic.com>
Signed-off-by: mmalac <mmalac@sygic.com>
…andling Signed-off-by: mmalac <mmalac@sygic.com>
Signed-off-by: mmalac <mmalac@sygic.com>
Signed-off-by: mmalac <mmalac@sygic.com>
Signed-off-by: mmalac <mmalac@sygic.com>
Signed-off-by: mmalac <mmalac@sygic.com>
…ation Signed-off-by: mmalac <mmalac@sygic.com>
Signed-off-by: mmalac <mmalac@sygic.com>
mairo744
force-pushed
the
chore/laminas-sm-v4
branch
from
f4c5744 to
7ef01ff
Compare
… SerializableStrategy Signed-off-by: mmalac <mmalac@sygic.com>
gsteel
approved these changes
Jul 8, 2025
Comment on lines
+21
to
+28
| <issueHandlers> | ||
| <InternalClass> | ||
| <errorLevel type="suppress"> | ||
| <file name="test/HydratorPluginManagerFactoryTest.php" /> | ||
| </errorLevel> | ||
| </InternalClass> | ||
| </issueHandlers> | ||
|
|
Member
There was a problem hiding this comment.
FYI, you can use something like this on class level doc blocks to stop Psalm complaining:
/**
* @psalm-internal \Laminas
* @psalm-internal \LaminasTest
*/
Author
Member
There was a problem hiding this comment.
There's some recent examples in the latest versions of laminas-filter and laminas-validator if that's helpful to you. Thanks for your work :)
gsteel
added
BC Break
Enhancement
QA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the package to support Laminas Service Manager v4. The changes involve updating dependency constraints in
composer.json:laminas/laminas-servicemanagerrequirement to^4.0.0in require-devI have tested these changes in our codebase where we use laminas-hydrator extensively, and everything works fine with Service Manager v4. All tests pass and the functionality remains unchanged.
I can also help with any improvements or refactoring suggestions if needed. I'm happy to contribute further to ensure smooth compatibility with the latest Service Manager version.
This is a QA improvement that ensures compatibility with the latest version of Laminas Service Manager while maintaining backward compatibility. The change targets the next minor branch as it's a QA improvement that doesn't change code behavior.