Skip to content

Comments

Refactor/rector code quality#140

Merged
gsteel merged 3 commits intolaminas:5.0.xfrom
mairo744:refactor/rector-code-quality
Aug 6, 2025
Merged

Refactor/rector code quality#140
gsteel merged 3 commits intolaminas:5.0.xfrom
mairo744:refactor/rector-code-quality

Conversation

@mairo744
Copy link

@mairo744 mairo744 commented Jul 30, 2025

Q A
Documentation no
Bugfix no
BC Break yes
New Feature no
RFC no
QA yes

Description

This pull request applies automated code quality improvements via Rector as it introduces internal refactors without altering behavior.

Changes include:

  • Refactoring to improve code quality based on Rector rulesets.
  • Enforcing final modifier for classes
  • Privatizing properties

mmalac added 2 commits July 30, 2025 17:47
Signed-off-by: mmalac <mmalac@sygic.com>
…nd core classes

Signed-off-by: mmalac <mmalac@sygic.com>
Signed-off-by: mmalac <mmalac@sygic.com>
@mairo744 mairo744 force-pushed the refactor/rector-code-quality branch from 2525986 to d72a7b9 Compare August 1, 2025 19:23
@mairo744 mairo744 requested a review from samsonasik August 5, 2025 18:02
@gsteel gsteel added the BC Break label Aug 6, 2025
@gsteel gsteel added this to the 5.0.0 milestone Aug 6, 2025
@gsteel gsteel self-assigned this Aug 6, 2025
@gsteel
Copy link
Member

gsteel commented Aug 6, 2025

Thank you @mairo744 👍

@gsteel gsteel merged commit d81b5b6 into laminas:5.0.x Aug 6, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants