Skip to content

Comments

Standardise Test Code Style + Additional QA with Rector#143

Merged
gsteel merged 3 commits intolaminas:5.0.xfrom
mairo744:refactor/rector-tests
Sep 11, 2025
Merged

Standardise Test Code Style + Additional QA with Rector#143
gsteel merged 3 commits intolaminas:5.0.xfrom
mairo744:refactor/rector-tests

Conversation

@mairo744
Copy link

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Refactored PHPUnit tests by applying Rector's PHPUnit code quality rules, except for the yield data provider changes.

Why

  • To improve test code readability, maintainability, and compliance with modern PHPUnit best practices.
  • This is a QA improvement only — no production code or behavior has been changed.

What was done

  • Applied Rector rules targeting PHPUnit code quality improvements.
  • Left data providers using yield unchanged to avoid unnecessary alterations.

mmalac added 2 commits August 12, 2025 21:08
…a provider

Signed-off-by: mmalac <mmalac@sygic.com>
Signed-off-by: mmalac <mmalac@sygic.com>
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mairo744 - Just a nitpick on replacing assertSame with assertEqualsWithDelta for floats. Happy to be told I'm wrong.

@gsteel gsteel self-assigned this Sep 10, 2025
@gsteel gsteel added this to the 5.0.0 milestone Sep 10, 2025
@gsteel gsteel added the QA Quality assurance tasks such as static analysis improvements label Sep 10, 2025
@gsteel gsteel changed the title Refactor/rector tests Standardise Test Code Style + Additional QA with Rector Sep 10, 2025
…his rector rule

Signed-off-by: mmalac <mmalac@sygic.com>
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mairo744 👍

@gsteel gsteel merged commit bcf1609 into laminas:5.0.x Sep 11, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA Quality assurance tasks such as static analysis improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants