Add keystore implementation and example.#18
Add keystore implementation and example.#18brotskydotcom wants to merge 5 commits intolandhb:mainfrom
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
- Coverage 78.33% 69.09% -9.24%
==========================================
Files 9 9
Lines 420 343 -77
==========================================
- Hits 329 237 -92
- Misses 91 106 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The `file` argument is deprecated in codecov-action@v5, but this commit leaves it in place (principle of least change).
|
Hi @landhb I've updated docs and tests to include the new module. Can you maybe review and pull or ask for changes? I'd like to get this released so I can release the next version of keyring. |
|
@brotskydotcom Sorry for the delay. Congrats on the retirement! Sorry, I misspoke, I'm running Debian + i3 with no Desktop Environment. So the 3rd largest group "Window Manager Only" in that chart. You're definitely right that KDE Wallet is often shipped with the KDE Plasma desktop environment, and implements the Secret Service API over dbus. Plus can always install the I'm wondering if this keystore code should live in it's own crate owned by So I wouldn't be opposed to making a new |
|
I pushed some of this initial code as a new private crate to |
|
Sorry to reply so late, been busy. Yes, I like the idea of moving all the "keyring bridge" implementations into separate crates, so I will pick up your work on linux-kernel-keystore and finalize it. Thanks for the suggestion and the work so far. |
This moves the keyutils credential store implementation out of the keyring crate and into this crate.
Fixes #17.