Skip to content

Add keystore implementation and example.#18

Open
brotskydotcom wants to merge 5 commits intolandhb:mainfrom
brotskydotcom:keystore
Open

Add keystore implementation and example.#18
brotskydotcom wants to merge 5 commits intolandhb:mainfrom
brotskydotcom:keystore

Conversation

@brotskydotcom
Copy link

This moves the keyutils credential store implementation out of the keyring crate and into this crate.

Fixes #17.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.09%. Comparing base (2e81f72) to head (3bfac58).
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   78.33%   69.09%   -9.24%     
==========================================
  Files           9        9              
  Lines         420      343      -77     
==========================================
- Hits          329      237      -92     
- Misses         91      106      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The `file` argument is deprecated in codecov-action@v5, but this commit leaves it in place (principle of least change).
@brotskydotcom
Copy link
Author

Hi @landhb I've updated docs and tests to include the new module. Can you maybe review and pull or ask for changes? I'd like to get this released so I can release the next version of keyring.

@landhb
Copy link
Owner

landhb commented Apr 28, 2025

@brotskydotcom Sorry for the delay.

Congrats on the retirement!

Sorry, I misspoke, I'm running Debian + i3 with no Desktop Environment. So the 3rd largest group "Window Manager Only" in that chart.

You're definitely right that KDE Wallet is often shipped with the KDE Plasma desktop environment, and implements the Secret Service API over dbus. Plus can always install the gnome-keyring debian package.

I'm wondering if this keystore code should live in it's own crate owned by open-source-cooperative. This crate was always just meant to be a very low-level wrapper around the syscalls and not an implementation of a keystore.

So I wouldn't be opposed to making a new open-source-cooperative/linux-kernel-keystore crate, plus then it will always be in-sync with open-source-collective/keyring-rs. And then if we ever add a persistence layer to that keystore it will just be a feature on that crate.

@landhb
Copy link
Owner

landhb commented Apr 28, 2025

I pushed some of this initial code as a new private crate to open-source-cooperative/linux-kernel-keystore, will try to touch up the docs.

@brotskydotcom
Copy link
Author

Sorry to reply so late, been busy. Yes, I like the idea of moving all the "keyring bridge" implementations into separate crates, so I will pick up your work on linux-kernel-keystore and finalize it. Thanks for the suggestion and the work so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add keystore support for keyring crate v4

3 participants