Fixed bug HuggingFacePipeline lacks#35095
Closed
Nitin75408 wants to merge 3 commits intolangchain-ai:masterfrom
Closed
Fixed bug HuggingFacePipeline lacks#35095Nitin75408 wants to merge 3 commits intolangchain-ai:masterfrom
Nitin75408 wants to merge 3 commits intolangchain-ai:masterfrom
Conversation
Merging this PR will not alter performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR title: fix(core,huggingface): add async streaming capability contract to prevent AttributeError
PR description:
Summary
Previously, ChatHuggingFace._astream would attempt to access async_client on HuggingFacePipeline instances, causing AttributeError since HuggingFacePipeline uses synchronous transformers pipelines and doesn't have an async_client attribute. This fix introduces an explicit capability declaration system where providers must declare their async streaming support, and the code checks this capability before attempting async operations.
Changes
Core Layer (langchain_core)
supports_async_streaming()method to BaseChatModel and BaseLLM as a capability contractHuggingFace Provider Layer
supports_async_streaming()returns Falsesupports_async_streaming()returns Truesupports_async_streaming()to check underlying LLM capabilityTesting
Architecture Benefits
This architectural approach provides several benefits:
Fixes #34134
Verification
All tests pass locally. The fix was verified by:
AI Assistance Disclaimer
This contribution was developed with assistance from AI coding tools. The architectural approach, implementation details, and test cases were reviewed and refined to ensure they follow LangChain patterns and best practices.