feat!: replace presuspend unit with dbus integration#755
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
- Coverage 95.81% 95.64% -0.17%
==========================================
Files 20 20
Lines 1338 1333 -5
Branches 115 116 +1
==========================================
- Hits 1282 1275 -7
+ Misses 46 45 -1
- Partials 10 13 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
languitar
force-pushed
the
feature/get-rid-of-presuspend-hook
branch
4 times, most recently
from
4eac828 to
da7814c
Compare
Instead of requiring a second systemd unit for detecting going into suspend, use dbus directly to get notified about an upcoming suspension. This avoids filesystem-based synchronization including the portalocker dependency. A few config options have been removed due not needing a woke up file anymore. Readthedocs build had to be bumped to Ubuntu 24.04 for having pygobject dependencies available. BREAKING CHANGE: dbus and pygobject are now a mandatory dependencies
languitar
force-pushed
the
feature/get-rid-of-presuspend-hook
branch
from
da7814c to
5c2a080
Compare
|
🎉 This PR is included in version 10.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of requiring a second systemd unit for detecting going into suspend, use dbus directly to get notified about an upcoming suspension. This avoids filesystem-based synchronization including the portalock dependency.
A few config options have been removed due not needed a woke up file anymore.
BREAKING CHANGE: dbus and pygobject are now mandatory dependencies