Fix normalizeCommand() splitting absolute paths containing spaces #553
+169
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When agents use useAbsolutePathForMcp(), getPhpPath() returns PHP_BINARY which on macOS with Herd resolves to a path inside "Application Support" (containing a space). The normalizeCommand() method splits on spaces, breaking the command into an invalid executable path. This adds a check to skip splitting when the command is an absolute path (Unix / or Windows drive letter), preserving paths with spaces while maintaining existing behavior for relative/compound commands. Fixes laravel#549 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
digitall-it
force-pushed
the
fix/normalize-command-spaces-in-path
branch
from
18c2fda to
753cc9e
Compare
There was a problem hiding this comment.
Pull request overview
Updates Agent::normalizeCommand() to avoid splitting absolute executable paths that may contain spaces (e.g. Herd’s PHP binary on macOS), ensuring generated MCP configs keep the full command path intact.
Changes:
- Add an absolute-path short-circuit to
normalizeCommand()for Unix (/…) and Windows drive-letter (C:\…) paths. - Add unit tests covering absolute Unix/Windows paths (with/without spaces) and file-based MCP config output for spaced paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Install/Agents/Agent.php |
Adjusts command normalization to preserve absolute paths and avoid breaking MCP command fields when paths contain spaces. |
tests/Unit/Install/Agents/AgentTest.php |
Adds regression tests ensuring absolute paths (incl. with spaces) aren’t split and file-based MCP output is correct. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
normalizeCommand()when the command is an absolute path (Unix/or Windows drive letterC:\), as these may contain spaces (e.g. macOSApplication Support)valet phpordocker exec container phpFixes #549
Related: #411, #539
Test Plan
🤖 Generated with Claude Code