Skip to content

[REVIEW]: Icon component#2

Open
lastnamearya wants to merge 334 commits intomasterfrom
integration/icon-component
Open

[REVIEW]: Icon component#2
lastnamearya wants to merge 334 commits intomasterfrom
integration/icon-component

Conversation

@lastnamearya
Copy link
Owner

Description

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@lastnamearya lastnamearya marked this pull request as ready for review March 26, 2020 20:07
@lastnamearya lastnamearya reopened this May 18, 2020
@lastnamearya lastnamearya changed the title [DO NOT MERGE]: Icon component [REVIEW]: Icon component May 18, 2020
lastnamearya and others added 26 commits May 19, 2020 02:16
* flush logger on shutdown

* use rmLoggerSet instead of flushLogStr

* add changelog
fix bug which was not allowing the allowlist to be imported
…#4801)

* flush log buffer on exception in mkWaiApp

* add comment to explain the introduced change

* add changelog
sezgi and others added 30 commits July 8, 2020 13:27
* server: call the webhook asynchronosly in event triggers
…graphql-engine into integration/icon-component
The current idle GC settings seem never to cause idle GC to trigger.
The changes here at least help memory usage to look more reasonable when
running certain benchmarks, and speculatively could partially fix some
memory leaks users have reported.

See ourIdleGC for details.

Referencing canonical memory issue hasura#3388
…asura#5374)

* Pass environment variables around as a data structure, via @sordina

* Resolving build error

* Adding Environment passing note to changelog

* Removing references to ILTPollerLog as this seems to have been reintroduced from a bad merge

* removing commented-out imports

* Language pragmas already set by project

* Linking async thread

* Apply suggestions from code review

Use `runQueryTx` instead of `runLazyTx` for queries.

* remove the non-user facing entry in the changelog

Co-authored-by: Phil Freeman <paf31@cantab.net>
Co-authored-by: Phil Freeman <phil@hasura.io>
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* docs: note libkrb5-dev dep on Debian, update GHC version

* docs: note openssl/libssl-dev requirements on Debian
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
…asura#5391)

Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.