Fallback to rsync returncode when logfile is not created to detect errors#209
Open
fthiery wants to merge 1 commit intolaurent22:masterfrom
Open
Fallback to rsync returncode when logfile is not created to detect errors#209fthiery wants to merge 1 commit intolaurent22:masterfrom
fthiery wants to merge 1 commit intolaurent22:masterfrom
Conversation
…e is not available
This was referenced Apr 29, 2020
shmilee
added a commit
to shmilee/arch-time-backup
that referenced
this pull request
Sep 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All rsync error detection is based on the contents of the logfile. If the errors are not in the file, or if the logfile is not present, the backup script assumes everything went fine (!!!).
This PR uses the returncode as additional condition to marking the backup as successful.