Sistent Card Component by Anand-Theertha · Pull Request #6117 · layer5io/layer5

Anand-Theertha · 2024-12-09T07:44:20Z

Description

This PR fixes #5908. This PR adds a Card component to the Sistent components. Following are a few screenshots of how the implementation looks:

Notes for Reviewers

Signed commits

Yes, I signed my commits.

l5io · 2024-12-09T07:57:28Z

🚀 Preview for commit 33df114 at: https://6756a2a4e25791afc5b16274--layer5.netlify.app

l5io · 2024-12-09T08:44:26Z

🚀 Preview for commit ade40a3 at: https://6756ad5a8a59a4c1a351345a--layer5.netlify.app

leecalcote · 2024-12-09T20:29:45Z

Thank you, @Anand-Theertha 👍

Vidit-Kushwaha

@Anand-Theertha I have reviewed your PR I have put some comments; you can look into it

Vidit-Kushwaha · 2024-12-14T09:07:57Z

src/sections/Projects/Sistent/components/card/index.js

Text on the card is not properly visible Can you use other shades?

Vidit-Kushwaha · 2024-12-14T09:12:32Z

src/sections/Projects/Sistent/components/card/code.js

+import { useStyledDarkMode } from "../../../../../theme/app/useStyledDarkMode";
+
+const codes = [
+  `const cardOutlined = (


Rather than creating a new component, you can directly pass as a child component to Card. So that I will be easier to copy for developers in the future.

I made it this way to keep the code modular and abstract to make it more reusable. Do you still suggest I add this as a child component? @Vidit-Kushwaha

Vidit-Kushwaha · 2024-12-14T09:14:24Z

src/sections/Projects/Sistent/components/card/guidance.js

Same increase in contrast between the text and background.

Anand-Theertha · 2024-12-14T09:39:22Z

Will make these changes, thanks @Vidit-Kushwaha

Vidit-Kushwaha · 2024-12-15T06:21:51Z

Hi @Anand-Theertha Facing issues merging your PR in Sistent?

We are conducting a special tutorial on this Monday, December 16, 2024, at 7 AM Central (6:30 PM IST) in the website meeting.

We'll cover:

Navigating the Sistent repo
Setting up locally
Helping your initial pull request to be merged

Get more information: here

👥 Get involved:

Explore the Newcomers’ Form.
Check out the meeting minutes.
Join the community calendar.

Don’t miss out. 🚀

sudhanshutech · 2024-12-19T01:36:50Z

@Anand-Theertha did you made changes based on feedback yet?

sudhanshutech · 2024-12-22T10:56:16Z

@Anand-Theertha checking in again?

Anand-Theertha · 2024-12-22T10:58:46Z

Will push these changes today, thanks for the reminder @sudhanshutech

sudhanshutech · 2024-12-25T03:52:33Z

?

SAHU-01 · 2025-01-05T14:46:01Z

Hi @Anand-Theertha, would appreciate if you could implement the reviews and push the changes , so that we can merge this?

Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Signed-off-by: Vrushabh <vrushabhgawas14@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Remove 404 link, and swap for 'Appears on publication' content Fixes layer5io#5885 Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Remove unused import Button Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

….mdx Signed-off-by: Lee Calcote <leecalcote@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

… page Signed-off-by: Lee Calcote <lee.calcote@layer5.io> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

…rn themes Signed-off-by: Lee Calcote <lee.calcote@layer5.io> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Signed-off-by: Lee Calcote <lee.calcote@layer5.io> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Signed-off-by: Shivam Gupta <sudhanshudasgupta9@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Signed-off-by: Ajay Singh <37625112+Ajay-singh1@users.noreply.github.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Signed-off-by: l5io <ci@layer5.io> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Signed-off-by: ritik-malik <ritik18406@iitd.ac.in> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Co-authored-by: Vidit Kushwaha <viditkushwaha530@gmail.com> Signed-off-by: maalik <ritik18406@iiitd.ac.in> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) from 7.36.1 to 7.37.3. - [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.36.1...v7.37.3) --- updated-dependencies: - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Bumps [@emotion/styled](https://github.com/emotion-js/emotion) from 11.13.0 to 11.14.0. - [Release notes](https://github.com/emotion-js/emotion/releases) - [Changelog](https://github.com/emotion-js/emotion/blob/main/CHANGELOG.md) - [Commits](https://github.com/emotion-js/emotion/compare/@emotion/styled@11.13.0...@emotion/styled@11.14.0) --- updated-dependencies: - dependency-name: "@emotion/styled" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Bumps [swiper](https://github.com/nolimits4web/Swiper) from 10.3.1 to 11.1.15. - [Release notes](https://github.com/nolimits4web/Swiper/releases) - [Changelog](https://github.com/nolimits4web/swiper/blob/master/CHANGELOG.md) - [Commits](nolimits4web/swiper@v10.3.1...v11.1.15) --- updated-dependencies: - dependency-name: swiper dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Signed-off-by: Shivam Gupta <sudhanshudasgupta9@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Signed-off-by: TheFaheem <faheemmushtaq89@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Signed-off-by: Shivam Gupta <sudhanshudasgupta9@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

l5io · 2025-01-05T16:57:17Z

🚀 Preview for commit 4d0db2c at: https://677ab9604f3ddfa7b38228fb--layer5.netlify.app

Anand-Theertha · 2025-01-09T10:51:03Z

I pushed my recent changes, but when I tried to follow the steps for DCO a lot more commits from the master branch were pushed. Can someone please guide me as to what can be done to push just my changes?

Vidit-Kushwaha · 2025-01-15T20:25:45Z

I pushed my recent changes, but when I tried to follow the steps for DCO a lot more commits from the master branch were pushed. Can someone please guide me as to what can be done to push just my changes?

you can create a separate new PR with required changes that can be added or you can cheery pick commits

Anand-Theertha · 2025-01-17T04:15:50Z

Another PR has been created with only the required changes.

github-actions bot added the project/sistent label Dec 9, 2024

Anand-Theertha mentioned this pull request Dec 9, 2024

Card sistent component #6085

Closed

1 task

Anand-Theertha force-pushed the sistent-card branch from 33df114 to ade40a3 Compare December 9, 2024 08:29

leecalcote requested a review from Vidit-Kushwaha December 9, 2024 20:29

Vidit-Kushwaha suggested changes Dec 14, 2024

View reviewed changes

Anand-Theertha and others added 15 commits January 5, 2025 16:42

Initial Commit

bcced6b

Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Card Component: Sistent

6cbd96f

Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Fixed lint issues: unused variables

1b345e8

Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Fixed lint issues: unused variables

ca42a7d

Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Review Updates

0a39a84

Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

made row to flex-wrap

a01c75d

Signed-off-by: Vrushabh <vrushabhgawas14@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

fix: remove 404 link

d8df268

Remove 404 link, and swap for 'Appears on publication' content Fixes layer5io#5885 Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

refactor: remove unused import

56fc911

Remove unused import Button Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Update src/collections/service-mesh-books/service-mesh-patterns/index…

5cbe626

….mdx Signed-off-by: Lee Calcote <leecalcote@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Enhance feature data processing and update JSON structure for pricing…

361ae8d

… page Signed-off-by: Lee Calcote <lee.calcote@layer5.io> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Remove unused theme style files from blog, classic, hosting, and mode…

98f764c

…rn themes Signed-off-by: Lee Calcote <lee.calcote@layer5.io> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Refactor Kanvas banner styles for improved layout and responsiveness

1fb4aa2

Signed-off-by: Lee Calcote <lee.calcote@layer5.io> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

pricing

6772986

Signed-off-by: Lee Calcote <lee.calcote@layer5.io> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

pricing

45be214

Signed-off-by: Lee Calcote <lee.calcote@layer5.io> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Clear subscription tier values in feature data JSON for pricing section

9cabd09

Signed-off-by: Lee Calcote <lee.calcote@layer5.io> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

ShivamCoder23 and others added 16 commits January 5, 2025 16:42

add package

fcb0ecf

Signed-off-by: Shivam Gupta <sudhanshudasgupta9@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Make member profile Inactive

07edf35

Signed-off-by: Ajay Singh <37625112+Ajay-singh1@users.noreply.github.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Update index.mdx

3a14f42

Signed-off-by: Ajay Singh <37625112+Ajay-singh1@users.noreply.github.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

[Docs] Generated documentation for Integration

aa9d456

Signed-off-by: l5io <ci@layer5.io> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

added new community memeber: Ahmed Hendawy

eb8acd2

Signed-off-by: ritik-malik <ritik18406@iitd.ac.in> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

added member profile for Vidit Kushwaha

ff881bc

Signed-off-by: ritik-malik <ritik18406@iitd.ac.in> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Update src/collections/members/vidit-kushwaha/index.mdx

4641e22

Co-authored-by: Vidit Kushwaha <viditkushwaha530@gmail.com> Signed-off-by: maalik <ritik18406@iiitd.ac.in> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

fix correct sitemap url for roboto

a72f5c5

Signed-off-by: Shivam Gupta <sudhanshudasgupta9@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

fix: Ensure modal appears above iframe by adjusting z-index

8ff8289

Signed-off-by: TheFaheem <faheemmushtaq89@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

convert to import statement to follow esm module

4b42387

Signed-off-by: Shivam Gupta <sudhanshudasgupta9@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

make feature file to follow esm modules

ebf827a

Signed-off-by: Shivam Gupta <sudhanshudasgupta9@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

named import

8ae1c68

Signed-off-by: Shivam Gupta <sudhanshudasgupta9@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

reconfigure the import

4d0db2c

Signed-off-by: Shivam Gupta <sudhanshudasgupta9@gmail.com> Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>

Anand-Theertha force-pushed the sistent-card branch from ad5e378 to 4d0db2c Compare January 5, 2025 16:42

github-actions bot added project/meshery area/blog New posts or new blog functionality area/community area/learn Related to /learn section project/kanvas area/site-config area/ci area/core-styles labels Jan 5, 2025

Anand-Theertha closed this Jan 17, 2025

Comments

Conversation

Anand-Theertha commented Dec 9, 2024

Uh oh!

l5io commented Dec 9, 2024

Uh oh!

l5io commented Dec 9, 2024

Uh oh!

leecalcote commented Dec 9, 2024

Uh oh!

Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

Uh oh!

Vidit-Kushwaha Dec 14, 2024

Choose a reason for hiding this comment

Uh oh!

Vidit-Kushwaha Dec 14, 2024

Choose a reason for hiding this comment

Uh oh!

Anand-Theertha Dec 24, 2024

Choose a reason for hiding this comment

Uh oh!

Vidit-Kushwaha Dec 14, 2024

Choose a reason for hiding this comment

Uh oh!

Anand-Theertha commented Dec 14, 2024

Uh oh!

Vidit-Kushwaha commented Dec 15, 2024

Uh oh!

sudhanshutech commented Dec 19, 2024

Uh oh!

sudhanshutech commented Dec 22, 2024

Uh oh!

Anand-Theertha commented Dec 22, 2024

Uh oh!

sudhanshutech commented Dec 25, 2024

Uh oh!

SAHU-01 commented Jan 5, 2025

Uh oh!

l5io commented Jan 5, 2025

Uh oh!

Anand-Theertha commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vidit-Kushwaha commented Jan 15, 2025

Uh oh!

Anand-Theertha commented Jan 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

Anand-Theertha commented Jan 9, 2025 •

edited

Loading