Add toggle-button component#6127
Conversation
eyeaadil
force-pushed
the
add-toggle-button-component
branch
from
bb056ec to
fe4e389
Compare
|
🚀 Preview for commit fe4e389 at: https://6764364266069e46100ebd59--layer5.netlify.app |
|
@l5io ,can you please review this PR? |
Pratik-050
left a comment
Pratik-050
left a comment
There was a problem hiding this comment.
Also make sure to include a screenshot or screen recording of the changes you've made, that'll make the review process easier.
Revert the changes in package-lock.json and gatsby-node.js
|
🚀 Preview for commit 1f86b76 at: https://6764e31e62c055bf7dc6cd61--layer5.netlify.app |
|
🚀 Preview for commit ee92d60 at: https://6764ee9243e3a0d6fe4821ce--layer5.netlify.app |
|
@Vidit-Kushwaha ,can you please review this? |
|
@eyeaadil still I can see changes in package.json and gatsby-node.js |
sudhanshutech
left a comment
sudhanshutech
left a comment
There was a problem hiding this comment.
@eyeaadil revert changes in package lock file
|
@eyeaadil Please add it as an agenda item to the meeting minutes. |
Vidit-Kushwaha
left a comment
Vidit-Kushwaha
left a comment
There was a problem hiding this comment.
@eyeaadil I have added a few comments. You can look into it
|
🚀 Preview for commit 787218b at: https://676cd9847770b4210ed2db12--layer5.netlify.app |
|
🚀 Preview for commit 24a1a2d at: https://676f71b18b0d230ae93b1da2--layer5.netlify.app |
eyeaadil
force-pushed
the
add-toggle-button-component
branch
from
24a1a2d to
9155193
Compare
Signed-off-by: eyeaadil <madil9227583@gmail.com>
Signed-off-by: eyeaadil <madil9227583@gmail.com>
Signed-off-by: eyeaadil <madil9227583@gmail.com>
Signed-off-by: eyeaadil <madil9227583@gmail.com>
Signed-off-by: eyeaadil <madil9227583@gmail.com>
Signed-off-by: eyeaadil <madil9227583@gmail.com>
eyeaadil
force-pushed
the
add-toggle-button-component
branch
from
9155193 to
4e30957
Compare
Signed-off-by: eyeaadil <madil9227583@gmail.com>
|
🚀 Preview for commit 22dd684 at: https://676f7d134e307413f8e3317a--layer5.netlify.app |
|
@eyeaadil looks like you've implemented the recommended changes, please add it as an agenda item to the meeting minutes. |
Vidit-Kushwaha
left a comment
Vidit-Kushwaha
left a comment
There was a problem hiding this comment.
@eyeaadil I have given you some input; otherwise, It look good to me 🙌
Signed-off-by: eyeaadil <madil9227583@gmail.com>
|
🚀 Preview for commit 4d91016 at: https://6775837cc3164cd54fa04d7c--layer5.netlify.app |
|
@Vidit-Kushwaha @SAHU-01 , now can you please review this? If there are still any issues, please let me know. |
|
@eyeaadil revert you change form package-lock json please |
Signed-off-by: eyeaadil <madil9227583@gmail.com>
|
🚀 Preview for commit 0de525e at: https://6776e4ace1dbb39360c32a4d--layer5.netlify.app |
i revert the changes in package-lock.json ,now can review this ? |
|
@sudhanshutech @SAHU-01 @Vidit-Kushwaha ,can you please review and merge this PR if there is no changes needed. |
Vidit-Kushwaha
left a comment
Vidit-Kushwaha
left a comment
There was a problem hiding this comment.
@eyeaadil, Looks good to me. @sudhanshutech we can merge into master
|
@sudhanshutech , can you please review this and merge this PR if there is no changes needed. |
7 participants
Description
This PR fixes #5958
Notes for Reviewers
For complete changes check the given link
https://6764ee9243e3a0d6fe4821ce--layer5.netlify.app/projects/sistent/components/toggle-button/guidance
ScreenShot
Signed commits