Skip to content

Comments

make-tier-comparison-header-sticky#6151

Closed
eyeaadil wants to merge 1 commit intolayer5io:masterfrom
eyeaadil:make-tier-comparison-header-sticky
Closed

make-tier-comparison-header-sticky#6151
eyeaadil wants to merge 1 commit intolayer5io:masterfrom
eyeaadil:make-tier-comparison-header-sticky

Conversation

@eyeaadil
Copy link
Contributor

@eyeaadil eyeaadil commented Jan 3, 2025

Description

This PR fixes #6122

Notes for Reviewers

Preview for commit:https://677805329d3a5b036e174e6e--layer5.netlify.app/

After changes
image

image

Signed commits

  • Yes, I signed my commits.

Signed-off-by: eyeaadil <madil9227583@gmail.com>
@l5io
Copy link
Contributor

l5io commented Jan 3, 2025

🚀 Preview for commit 09c907a at: https://677805329d3a5b036e174e6e--layer5.netlify.app

@Ajay-singh1
Copy link
Member

Screenshot_20250103-210841_Chrome
Fix the borders

@eyeaadil
Copy link
Contributor Author

eyeaadil commented Jan 3, 2025

Screenshot_20250103-210841_Chrome Fix the borders

can you please specify which border you are talking about?

@Ajay-singh1
Copy link
Member

Screenshot from 2025-01-03 21-35-10

This border

Screencast.from.2024-12-31.18-53-44.mp4

And make it something like this so that when the user scrolls the header stucks to the top until it reaches the bottom of the container.

@leecalcote
Copy link
Member

Is this PR a duplicate of #6138?

@Venkata-Sai-Vishwanath-robo
Copy link
Member

This PR looks pretty neat, but there is an extra space at the end of the table. This space grows larger as the window size decreases, which might misleadingly suggest that something hasn't rendered correctly or is still loading. A better use of this space could be to place call-to-action buttons there as well. Positioning the buttons in this spot would make it more convenient for users to access the free trial option without needing to scroll back to the top.
The call-to-action buttons could be added after the approval from @leecalcote

image

image

@leecalcote leecalcote requested a review from SAHU-01 January 5, 2025 15:48
@Venkata-Sai-Vishwanath-robo
Copy link
Member

Screenshot from 2025-01-03 21-35-10

This border

Screencast.from.2024-12-31.18-53-44.mp4
And make it something like this so that when the user scrolls the header stucks to the top until it reaches the bottom of the container.

@Ajay-singh1 I like the idea of having the header stick to the top, as shown in the video. However, don’t you think the table's content, including the expanded sections, might be too extensive? This could force users to scroll through everything, even if they’re not interested.

@Ajay-singh1
Copy link
Member

@Venkata-Sai-Vishwanath-robo Yeah! I agree with you.

@vishalvivekm
Copy link
Contributor

@eyeaadil
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

@stale
Copy link

stale bot commented Apr 26, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 26, 2025
@stale
Copy link

stale bot commented Apr 27, 2025

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue/stale Issue has not had any activity for an extended period of time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Pricing] Make Tier Comparison Header Sticky

6 participants