fix: Ensure modal appears above iframe by adjusting z-index#6152
Merged
leecalcote merged 2 commits intolayer5io:masterfrom Jan 5, 2025
Merged
fix: Ensure modal appears above iframe by adjusting z-index#6152leecalcote merged 2 commits intolayer5io:masterfrom
leecalcote merged 2 commits intolayer5io:masterfrom
Conversation
Contributor
|
🚀 Preview for commit 626408f at: https://677901b7ba784ec5630df2f3--layer5.netlify.app |
FaheemOnHub
force-pushed
the
bug/faheemonhub/6150
branch
from
626408f to
1b9d30e
Compare
Contributor
|
🚀 Preview for commit 1b9d30e at: https://677913b6b333f8cc383ea16d--layer5.netlify.app |
leecalcote
requested changes
Jan 4, 2025
Member
leecalcote
left a comment
leecalcote
left a comment
There was a problem hiding this comment.
@FaheemOnHub thanks for identifying and working on this issue.
Signed-off-by: TheFaheem <faheemmushtaq89@gmail.com>
FaheemOnHub
force-pushed
the
bug/faheemonhub/6150
branch
from
1b9d30e to
5814eb4
Compare
Contributor
|
🚀 Preview for commit 5814eb4 at: https://67799bcc4f3ddf70ec822837--layer5.netlify.app |
Contributor
|
🚀 Preview for commit 44c437e at: https://677a027c96970bd9a77bde93--layer5.netlify.app |
leecalcote
approved these changes
Jan 5, 2025
Member
leecalcote
left a comment
leecalcote
left a comment
There was a problem hiding this comment.
Looks good. Thanks, @FaheemOnHub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #6150 issue where the modal was being obscured by the iframe. Adjusted the z-index in the navigation styles to resolve the problem.
Signed-off-by: Faheem Mushtaq faheemmushtaq89@gmail.com
Notes for Reviewers
Signed commits