Skip to content

Comments

move slick carousel theme to global#6164

Merged
sudhanshutech merged 2 commits intolayer5io:masterfrom
ShivamCoder23:css/conflict
Jan 9, 2025
Merged

move slick carousel theme to global#6164
sudhanshutech merged 2 commits intolayer5io:masterfrom
ShivamCoder23:css/conflict

Conversation

@ShivamCoder23
Copy link
Contributor

@ShivamCoder23 ShivamCoder23 commented Jan 5, 2025

Description

This PR moves the slick-carousel theme module from specific file to global or root level with font css module. Since font was earlier used in root level but slick-carousel theme was used as specific files that's why webpack was not able to generate the correct order to implement them.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shivam Gupta <sudhanshudasgupta9@gmail.com>
@l5io
Copy link
Contributor

l5io commented Jan 5, 2025

🚀 Preview for commit 9fdd79a at: https://677a7767dd610f577a0b6dc2--layer5.netlify.app

@sudhanshutech
Copy link
Member

@leecalcote @vishalvivekm @SAHU-01 can anyone please test with this pr if there still conflict warning ?

@leecalcote leecalcote self-requested a review January 5, 2025 12:53
@SAHU-01
Copy link
Contributor

SAHU-01 commented Jan 5, 2025

@leecalcote @vishalvivekm @SAHU-01 can anyone please test with this pr if there still conflict warning ?

@sudhanshutech I can't see this PR raising a conflict warning anymore.

@sudhanshutech
Copy link
Member

@vishalvivekm can you?

@sudhanshutech
Copy link
Member

sudhanshutech commented Jan 6, 2025

I am waiting for others reviews here.

@leecalcote
Copy link
Member

Looking…

@leecalcote
Copy link
Member

@sudhanshutech, I don’t see a carousel in mobile view. Is this intentional? https://layer5.io/community

@leecalcote
Copy link
Member

I checked that page in desktop view as well and don't see a slider on the /community page...

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporate the latest slider package version - #6141

@sudhanshutech
Copy link
Member

sudhanshutech commented Jan 7, 2025

@leecalcote there is no slider at community currently its being commented out. Other pages which are using slider are few these:

  1. https://layer5.io/cloud-native-management/meshery (the three screenshot images vertically )
  2. https://layer5.io/cloud-native-management/kanvas (the testimonials at bottom)

they are working as expected

Signed-off-by: Shivam Gupta <sudhanshudasgupta9@gmail.com>
@l5io
Copy link
Contributor

l5io commented Jan 7, 2025

🚀 Preview for commit e5a2549 at: https://677d1ef14c89e586e26cbe70--layer5.netlify.app

@sudhanshutech
Copy link
Member

the version is upgraded.

@leecalcote leecalcote requested a review from Ajay-singh1 January 8, 2025 02:23
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@sudhanshutech sudhanshutech merged commit 9aeb1ee into layer5io:master Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants