fix: add missing externalLink property to menu items for proper link handling#6179
Merged
leecalcote merged 1 commit intolayer5io:masterfrom Jan 7, 2025
Merged
Conversation
…handling Signed-off-by: TheFaheem <faheemmushtaq89@gmail.com>
Contributor
|
🚀 Preview for commit 9367e83 at: https://677c2284fa0c930df73a7edd--layer5.netlify.app |
leecalcote
reviewed
Jan 7, 2025
Member
There was a problem hiding this comment.
Thank you, @FaheemOnHub. I see where two of the references have been made external. Good. Were there any others in the site other than these two?
leecalcote
approved these changes
Jan 7, 2025
Contributor
Author
|
Thank you for the feedback! I checked the site and didn't find any other instances of Link warnings related to external references. It seems the two updated references were the only ones causing the issue. However, if there's a specific section or component, you'd like me to review again, please let me know, and I'd be happy to take another look. |
Member
|
Thanks for confirming. It sounds like you've covered all the bases here. Excellent. 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #6173 and #6172, as both were related to same issue. This PR fixes an issue where certain menu items were incorrectly using the Link component for external URLs due to missing the externalLink property.
Gatsby's Link component should only be used for internal links, as per their guidelines. This caused warnings like:
"External link https://docs.layer5.io/ was detected in a Link component. Use the Link component only for internal links. See: https://gatsby.dev/internal-links"Notes for Reviewers
Signed commits