Skip to content

Comments

refactor: remove the gradient from form fields#6200

Closed
vladboisa wants to merge 3 commits intolayer5io:masterfrom
vladboisa:patch-1
Closed

refactor: remove the gradient from form fields#6200
vladboisa wants to merge 3 commits intolayer5io:masterfrom
vladboisa:patch-1

Conversation

@vladboisa
Copy link
Contributor

Description

This PR fixes #6199

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Vlad Boisa <60569670+vladboisa@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Jan 21, 2025

🚀 Preview for commit d4cf0db at: https://678f20027eb45ba394360fe1--layer5.netlify.app

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please ensure that we are using some sort of color other than straight white, which in dark mode is offensive to the eyes.

@leecalcote
Copy link
Member

Thanks so much for working on this, @vladboisa 👍

Signed-off-by: Vlad Boisa <60569670+vladboisa@users.noreply.github.com>
@vladboisa
Copy link
Contributor Author

Thank you. Please ensure that we are using some sort of color other than straight white, which in dark mode is offensive to the eyes.

Yep, no problem. I think Off White (#FAF9F6): The Soft Touch fit's perfectly here! :)
Thanks for opportunity to help the Open-source community.

@l5io
Copy link
Contributor

l5io commented Jan 24, 2025

🚀 Preview for commit d7f1744 at: https://67930d06f95947544b6f77cc--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

Thank you for your contribution! @vladboisa
Let's discuss this during the website call on Monday at 7 AM CT.

adding it as an agenda item to the meeting minutes.

Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladboisa
take a look at following screenshots:
from: https://67930d06f95947544b6f77cc--layer5.netlify.app/company/contact

  • invisible text [in dark theme]
    Screenshot from 2025-01-27 16-21-45
  • light theme
    Screenshot from 2025-01-27 16-21-58

Signed-off-by: Vlad Boisa <60569670+vladboisa@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Jan 31, 2025

🚀 Preview for commit 93277d2 at: https://679d0519cdb01c1b029a0bc7--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

vishalvivekm commented Feb 3, 2025

@vladboisa
Let's discuss this during the website call on Monday at 7 AM CT | 6:30 PM IST

adding it as an agenda item to the meeting minutes.

@vladboisa
Copy link
Contributor Author

@vladboisa Let's discuss this during the website call on Monday at 7 AM CT | 6:30 PM IST

adding it as an agenda item to the meeting minutes.

Thanks, now committed the new changes!

@vishalvivekm
Copy link
Contributor

Thank you @vladboisa
Do you mind sharing your changes on the sites' call today ? It'll be happening at 7 AM CT today here: https://meet.layer5.io/websites

Meeting minutes: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit?usp=drivesdk

@leecalcote
Copy link
Member

@vishalvivekm, does this remain an open issue or has this been resolved?

@vishalvivekm
Copy link
Contributor

@vishalvivekm, does this remain an open issue or has this been resolved?

Resolved. Thank you @vladboisa for working on this, we'll not be able to accept this PR, since a fixing patch has already been merged and released.
Closing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[form] remove the gradient from form fields

4 participants