Added the List component to the sistent components page and updated the content.js file. by csengineer1990 · Pull Request #6219 · layer5io/layer5

csengineer1990 · 2025-02-02T12:10:51Z

Description

This PR addresses issue #5951 by adding the List component to the Sistent Components page. The necessary content and documentation for the List component have been included, along with updates to the relevant files to ensure consistency.

This PR fixes #5951

Notes for Reviewers
I have made the following changes:

Implemented and documented the List component.
Updated the content.js file to reflect these additions.

I have made the required changes as requested in the previous reviews and aligned them with the issue to ensure a proper resolution.
I would appreciate your review of these updates. Please let me know if any further refinements or additional changes are needed. Thank you!

Signed commits

Yes, I signed my commits.

…he content.js Signed-off-by: Roshan Goswami <csengineer23@gmail.com>

l5io · 2025-02-02T12:23:56Z

🚀 Preview for commit 5c557f3 at: https://679f638e6e5e0b86aee4c955--layer5.netlify.app

vishalvivekm · 2025-02-03T09:03:53Z

@csengineer1990
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

Vidit-Kushwaha · 2025-02-03T12:43:12Z

src/sections/Projects/Sistent/components/list/code-block.js

Not require to create a separate file for code-block.js you can directly import, so delete this file

Vidit-Kushwaha · 2025-02-03T12:48:30Z

src/sections/Projects/Sistent/components/list/code.js

Can you include example for the List controls like checkbox?

Vidit-Kushwaha

I have provided few feedback can you look @csengineer1990

sudhanshutech · 2025-02-04T10:42:49Z

src/sections/Projects/Sistent/components/list/code-block.js

+import React, { useState } from "react";
+import Code from "../../../../../components/CodeBlock";
+
+export const CodeBlock = ({ name, code }) => {


use existing codeblock and don't create a new one please

Signed-off-by: Roshan Goswami <csengineer23@gmail.com>

…oned in the previous request. Signed-off-by: Roshan Goswami <csengineer23@gmail.com>

csengineer1990 · 2025-02-15T12:39:07Z

Made the requested changes by adding examples of List control with checkboxes and removing code-block.js. Apologies for the delayed update. If any further changes are needed, please let me know.

l5io · 2025-02-15T12:45:56Z

🚀 Preview for commit 2a9bd74 at: https://67b08c32b7f3d319c41cfb1e--layer5.netlify.app

Vidit-Kushwaha

Looks Good to me

leecalcote · 2025-02-20T05:16:09Z

@csengineer1990 please have a look at the merge conflicts here.

csengineer1990 · 2025-02-21T04:15:54Z

@csengineer1990 please have a look at the merge conflicts here.

Yes, I will surely resolve the merge conflicts as soon as possible. Thanks for bringing it to my attention!

Signed-off-by: Roshan Goswami <csengineer23@gmail.com>

Signed-off-by: Roshan <68468678+csengineer1990@users.noreply.github.com>

l5io · 2025-02-22T04:40:15Z

🚀 Preview for commit fefa978 at: https://67b954e04b59d7b097203a3b--layer5.netlify.app

csengineer1990 · 2025-02-27T03:42:25Z

I have resolved the merge conflict. Please review the commit and let me know if there are any issues so that I can address them as soon as possible.

Vidit-Kushwaha

Approved 👍
Add this as an agenda item to the meeting minutes.

csengineer1990 · 2025-03-11T03:27:51Z

I have resolved the merge conflict. Please review the commit and let me know if there are any issues so that I can address them as soon as possible.

csengineer1990 · 2025-04-10T03:17:34Z

Approved 👍 Add this as an agenda item to the meeting minutes.

Hi, I’ve resolved the merge conflict and pushed the updated commit.
Kindly review when possible — if everything looks good, please consider merging it.
If there’s anything I’ve missed or done incorrectly, please let me know and I’ll fix it right away.
It’s been a while, so just following up. Thanks!

Signed-off-by: l5io <ci@layer5.io>

stale · 2025-06-27T00:33:36Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Signed-off-by: l5io <ci@layer5.io>

vr-varad · 2025-08-22T06:13:12Z

Hey @csengineer1990, Is this done from your side?
There are merge conflict that you might need to resolve.

Signed-off-by: l5io <ci@layer5.io>

csengineer1990 · 2025-08-24T03:41:02Z

Hey @csengineer1990, Is this done from your side? There are merge conflict that you might need to resolve.

Hi, I had completed this issue earlier and at that time everything was working fine. I haven’t re-downloaded the repo recently, but from the GitHub checks it looks like there are no merge conflicts and the branch can be merged. Please let me know if you still need me to make any additional updates.

Signed-off-by: l5io <ci@layer5.io>

Rajesh-Nagarajan-11 · 2025-09-23T15:12:04Z

any updates ?

Rajesh-Nagarajan-11 · 2025-10-02T16:59:11Z

Due to unwanted changes in feature_data.json + No response from authour leads to close this PR

Added the List component to the sistent components page and updated t…

5c557f3

…he content.js Signed-off-by: Roshan Goswami <csengineer23@gmail.com>

github-actions bot added the project/sistent label Feb 2, 2025

Vidit-Kushwaha reviewed Feb 3, 2025

View reviewed changes

src/sections/Projects/Sistent/components/list/code.js

Copy link

Contributor

Vidit-Kushwaha Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include example for the List controls like checkbox?

Vidit-Kushwaha suggested changes Feb 3, 2025

View reviewed changes

sudhanshutech suggested changes Feb 4, 2025

View reviewed changes

csengineer1990 added 2 commits February 15, 2025 17:43

Removed code-block.js file from the List component directory

321770f

Signed-off-by: Roshan Goswami <csengineer23@gmail.com>

Updated code.js with a List control example using checkboxes as menti…

2a9bd74

…oned in the previous request. Signed-off-by: Roshan Goswami <csengineer23@gmail.com>

Vidit-Kushwaha approved these changes Feb 17, 2025

View reviewed changes

csengineer1990 and others added 2 commits February 22, 2025 09:52

Resolved merge conflict in content.js by updating Id

6727d60

Signed-off-by: Roshan Goswami <csengineer23@gmail.com>

Merge branch 'master' into master

fefa978

Signed-off-by: Roshan <68468678+csengineer1990@users.noreply.github.com>

Vidit-Kushwaha approved these changes Mar 2, 2025

View reviewed changes

l5io added 3 commits April 22, 2025 00:53

Updated feature data from spreadsheet

cf0d4bc

Signed-off-by: l5io <ci@layer5.io>

Updated feature data from spreadsheet

9ca0544

Signed-off-by: l5io <ci@layer5.io>

Updated feature data from spreadsheet

d7a3f5e

Signed-off-by: l5io <ci@layer5.io>

stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jun 27, 2025

l5io added 3 commits July 19, 2025 00:58

Updated feature data from spreadsheet

10a7eb4

Signed-off-by: l5io <ci@layer5.io>

Updated feature data from spreadsheet

6c3bc34

Signed-off-by: l5io <ci@layer5.io>

Updated feature data from spreadsheet

716001e

Signed-off-by: l5io <ci@layer5.io>

l5io added 3 commits August 20, 2025 00:54

Updated feature data from spreadsheet

643560e

Signed-off-by: l5io <ci@layer5.io>

Updated feature data from spreadsheet

a8f463d

Signed-off-by: l5io <ci@layer5.io>

Updated feature data from spreadsheet

c959036

Signed-off-by: l5io <ci@layer5.io>

stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Aug 22, 2025

Updated feature data from spreadsheet

792b07e

Signed-off-by: l5io <ci@layer5.io>

l5io added 2 commits August 26, 2025 00:55

Updated feature data from spreadsheet

df2a74e

Signed-off-by: l5io <ci@layer5.io>

Updated feature data from spreadsheet

f31cf90

Signed-off-by: l5io <ci@layer5.io>

Rajesh-Nagarajan-11 closed this Oct 2, 2025

Comments

Conversation

csengineer1990 commented Feb 2, 2025

Uh oh!

l5io commented Feb 2, 2025

Uh oh!

vishalvivekm commented Feb 3, 2025

Uh oh!

Vidit-Kushwaha Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

Vidit-Kushwaha Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

Uh oh!

sudhanshutech Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

csengineer1990 commented Feb 15, 2025

Uh oh!

l5io commented Feb 15, 2025

Uh oh!

Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

Uh oh!

leecalcote commented Feb 20, 2025

Uh oh!

csengineer1990 commented Feb 21, 2025

Uh oh!

l5io commented Feb 22, 2025

Uh oh!

csengineer1990 commented Feb 27, 2025

Uh oh!

Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

Uh oh!

csengineer1990 commented Mar 11, 2025

Uh oh!

csengineer1990 commented Apr 10, 2025

Uh oh!

stale bot commented Jun 27, 2025

Uh oh!

vr-varad commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

csengineer1990 commented Aug 24, 2025

Uh oh!

Rajesh-Nagarajan-11 commented Sep 23, 2025

Uh oh!

Rajesh-Nagarajan-11 commented Oct 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

vr-varad commented Aug 22, 2025 •

edited

Loading