Skip to content

Comments

feat: add .nvmrc and .npmrc files#6238

Merged
vishalvivekm merged 6 commits intolayer5io:masterfrom
M-DEV-1:6229-nvmrc
Feb 24, 2025
Merged

feat: add .nvmrc and .npmrc files#6238
vishalvivekm merged 6 commits intolayer5io:masterfrom
M-DEV-1:6229-nvmrc

Conversation

@M-DEV-1
Copy link
Member

@M-DEV-1 M-DEV-1 commented Feb 14, 2025

Description

This PR fixes #6229

Notes for Reviewers

Node.js versions are generally backward compatible but without standardization, inconsistencies in versions can lead to dependency and build issues.

This PR adds a .nvmrc and .npmrc files to standardize the Node.js (and npm) versions.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1
Copy link
Member Author

M-DEV-1 commented Feb 14, 2025

I used package-lock.json and ran commands to filter and return the Node.js version to use. I manually verified this too.

After switching to this version, I ran all necessary setup commands (make lint, make setup, make site, gatsby develop, gatsby build). Everything executed successfully without errors.

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented Feb 14, 2025

Also, while running make lint

I'm encountering this,

/layer5/src/sections/Company/Contact/index.js
  10:8  warning  'ContactForm' is defined but never used. Allowed unused vars must match /React/u  no-unused-vars

/layer5/src/sections/General/Faq/index.js
  23:8  warning  'ContactFormModal' is defined but never used. Allowed unused vars must match /React/u  no-unused-vars

✖ 2 problems (0 errors, 2 warnings)

Should I comment them out since they are not being used, or should I leave them as it is?

@l5io
Copy link
Contributor

l5io commented Feb 14, 2025

🚀 Preview for commit e0e38e6 at: https://67afc7b0f82bc6a6cbac86a0--layer5.netlify.app

Signed-off-by: mahadevan <135952571+M-DEV-1@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Feb 15, 2025

🚀 Preview for commit 98ed19a at: https://67afd8c9a1674fe7c0366655--layer5.netlify.app

Signed-off-by: mahadevan <135952571+M-DEV-1@users.noreply.github.com>
Signed-off-by: mahadevan <135952571+M-DEV-1@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Feb 15, 2025

🚀 Preview for commit 7cf5f78 at: https://67afe1bb370323fb0c883959--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Feb 16, 2025

🚀 Preview for commit c9de928 at: https://67b20429d93208912badb462--layer5.netlify.app

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishalvivekm
Copy link
Contributor

I used package-lock.json and ran commands to filter and return the Node.js version to use. I manually verified this too.

After switching to this version, I ran all necessary setup commands (make lint, make setup, make site, gatsby develop, gatsby build). Everything executed successfully without errors.

✔️

@M-DEV-1 M-DEV-1 deleted the 6229-nvmrc branch March 3, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .nvmrc file to ensure consistency of Node versions across Layer5 repositories

4 participants