Skip to content

Comments

changed static colors to dynamic theme colors in Scenario.Card.style.js and LabsWrapper.style.js#6239

Closed
Fritozz-105 wants to merge 3 commits intolayer5io:masterfrom
Fritozz-105:interactive-labs-dark-mode
Closed

changed static colors to dynamic theme colors in Scenario.Card.style.js and LabsWrapper.style.js#6239
Fritozz-105 wants to merge 3 commits intolayer5io:masterfrom
Fritozz-105:interactive-labs-dark-mode

Conversation

@Fritozz-105
Copy link

@Fritozz-105 Fritozz-105 commented Feb 16, 2025

Description

This PR fixes #5286

Notes for Reviewers
Edited the styling files and changed the static color to blackToWhite, whiteToBlack, etc. so the color changes when toggling light/dark mode. I added a filter to the themeStyles.js because it said it wasn't advised to use a conditional for color changes.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Fritozz-105 <zengz1@ufl.edu>
@l5io
Copy link
Contributor

l5io commented Feb 16, 2025

🚀 Preview for commit aca22aa at: https://67b18e68eb0cffee127bac5b--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@Fritozz-105
Thank you for your contribution!
Let's discuss this during the website call on Today at 7 AM CT | 6:30 PM IST
adding it as an agenda item to the meeting minutes.

@SAHU-01
Copy link
Contributor

SAHU-01 commented Feb 17, 2025

Thank you so much for working on this!!!

image @Fritozz-105 the alignment seems broken, we'd want to have centre aligned cards.

Additionally, @vishalvivekm suggests having coloured logos in light theme, could you ensure that's taken care of?

@Fritozz-105
Copy link
Author

Fritozz-105 commented Feb 17, 2025

@SAHU-01
Yes, I’ll try to get this taken care of. I’ll let you all know if I cannot.
I just have a question, it seems like there is an alignment issue on the production build of the website. Shall I fix that or would a separate issue be better?

Signed-off-by: Fritozz-105 <zengz1@ufl.edu>
@l5io
Copy link
Contributor

l5io commented Feb 19, 2025

🚀 Preview for commit 1ae8f1d at: https://67b657cdcb08e2ccc8624c5c--layer5.netlify.app

Signed-off-by: Fritozz-105 <zengz1@ufl.edu>
@l5io
Copy link
Contributor

l5io commented Feb 19, 2025

🚀 Preview for commit 47d25d2 at: https://67b667e8929937f17eb6bd97--layer5.netlify.app

Copy link
Contributor

@Vidit-Kushwaha Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the background color of black to be a little strange. What's your thought, @vishalvivekm?

image

@stale
Copy link

stale bot commented Apr 26, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 26, 2025
@stale
Copy link

stale bot commented Apr 27, 2025

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue/stale Issue has not had any activity for an extended period of time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark mode on the Interactive Labs page doesn't display the correct colors

5 participants