[Components] Add Table component and update navigation links#6372
[Components] Add Table component and update navigation links#6372Souradip121 wants to merge 4 commits intolayer5io:masterfrom Souradip121:work-on-table
Conversation
Signed-off-by: Souradip Pal <souradip1000@gmail.com>
|
🚀 Preview for commit 8a1b0d8 at: https://67f11345ea4a3ebfac617338--layer5.netlify.app |
| import { | ||
| SistentThemeProvider, | ||
| Table, | ||
| TableBody, |
There was a problem hiding this comment.
don't use this table , we have already a component named responsive table in place use that to document. Including how columns and search are displayed as optional for tables. Checkout sistent and meshery for actual component
There was a problem hiding this comment.
Are you referring to ResponsiveDataTable @sudhanshutech ?
|
@Souradip121 adding it as an agenda item to the meeting minutes. |
|
🚀 Preview for commit 98d1195 at: https://67f3a3fe901b4bd31b38b456--layer5.netlify.app |
…roved responsiveness and features Signed-off-by: Souradip Pal <souradip1000@gmail.com>
|
🚀 Preview for commit 9fe7f9c at: https://67fb602a934d908cec982bb4--layer5.netlify.app |
|
|
@Souradip121 please add some data to these tables then it would look good, don't keep them empty |
|
atleast add these too(in guidance) @Souradip121 :
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
|
Hi @sudhanshutech |
|
@avni-mahajan If you want u can work on this issue!!!! |
|
@vr-varad, thank you and I will start working on this! |
6 participants
Description
This PR fixes #5962
Notes for Reviewers
Screen.Recording.2025-04-05.160804.mp4
After observing the progress made by @eyeaadil, I noticed that there was usage of @mui/material in his PR #6231, which should not be the case, as pointed out by @sudhanshutech in the review.
After reading the PR, I also found that he had not implemented proper navigation after adding table, and had used props from @mui/material, not from @layer5/sistent. Then I began studying Table component of @layer5/sistent where I found there was no Stripped Table variant, no Bordered Cells variant.
Therefore, I implemented the table component from Sistent without those variants and without any using Material UI.
I am going to create an issue for adding those variants of Table in Sistent. Another thing I noticed after going through the documentation of sistent components like Select there was usage of @mui/material and no import of Select from layer5/sistent
Signed commits