Publish avatar and avarat group component#6655
Conversation
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
|
🚀 Preview for commit b891d4c at: https://68812f4b4cb43daae40ca729--layer5.netlify.app |
vr-varad
left a comment
vr-varad
left a comment
There was a problem hiding this comment.
Mind adding these code snippets in code blocks? @LibenHailu
Sure, I used the previous PRs and didn’t see any comments regarding this, but it makes sense to move it into the code block. The Guidance section should focus solely on best practices and guidelines. I’ll update the change. @vr-varad |
|
Thank you for your contribution! Add it as an agenda item to the meeting minutes, if you would :) |
|
🚀 Preview for commit 5ff569e at: https://68870cf924631c99c6f75736--layer5.netlify.app |
|
any progress on this @LibenHailu |
|
🚀 Preview for commit 285bce2 at: https://688be820ea6db07ce839bfb7--layer5.netlify.app |
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
|
🚀 Preview for commit 6eca251 at: https://688cf32a76be913b02098421--layer5.netlify.app |
|
Hi @vr-varad, apologies for the timing it shouldn't have taken this long. I have made the updates please feel free to re-review them. |
leecalcote
left a comment
leecalcote
left a comment
There was a problem hiding this comment.
I think we're good to go here, @LibenHailu.
@sudhanshutech, do you think so, too?
sudhanshutech
left a comment
sudhanshutech
left a comment
There was a problem hiding this comment.
@LibenHailu why there is text inside the preview box, please move out from that. Looks very odd and else looks good
just one change need a fix @leecalcote then good to go |
…lass Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
|
🚀 Preview for commit 1864a61 at: https://6891b7d3a436e5f13395b984--layer5.netlify.app |
vr-varad
left a comment
vr-varad
left a comment
There was a problem hiding this comment.
@LibenHailu LGTM
Please Resolve the merge conflict and good to merge.
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
|
🚀 Preview for commit f47880d at: https://689a080a721ab716a848ced0--layer5.netlify.app |
|
@vr-varad conflict resolved |
Signed-off-by: Varad Gupta <114755221+vr-varad@users.noreply.github.com>
|
🚀 Preview for commit 5aa68cc at: https://68a85027d3bcdf5fe4a320a9--layer5.netlify.app |
5 participants
Description
This PR fixes #6189
Notes for Reviewers
This PR builds upon the previously raised PRs, addresses the feedback provided, and adds the missing components.
#6221
#6259
Signed commits