chore: Update to Sistent v0.16.8#7409
chore: Update to Sistent v0.16.8#7409saurabhraghuvanshii wants to merge 5 commits intolayer5io:masterfrom
Conversation
Signed-off-by: saurabhraghuvanshii <saurabhsraghuvanshi@gmail.com>
|
fix #7341 |
|
🚀 Preview for commit 3d9cc9d at: https://6984e995fc90821d2297b739--layer5.netlify.app |
leecalcote
left a comment
There was a problem hiding this comment.
@saurabhraghuvanshii, we're going to have repeat of our last interaction, I fear. The PR you've opened shouldn't be merged unless its an emergency. What needs to be done is to identify the root cause of why the automated dependency updates failed, fix that, and then make sure that the upgrade is completed.
|
@sistent/sistent declares @meshery/schemas as a peer dependency (in its package.json). Peer dependencies are not installed automatically by the package; the host application is expected to list and install them. The layer5 site did not have @meshery/schemas as a dependency, so the bundler could not resolve it when building code that uses sistent. |
|
🚀 Preview for commit d732f03 at: https://6996daa65455c655c7929af9--layer5.netlify.app |
Signed-off-by: saurabhraghuvanshii <saurabhsraghuvanshi@gmail.com>
|
🚀 Preview for commit a0acac2 at: https://6996e232e14bf16c2b5dc3cb--layer5.netlify.app |
|
for Now we can go with this PR. |
|
🚀 Preview for commit f27d74e at: https://6997cf0c10a2d7b12b91351d--layer5.netlify.app |
|
🚀 Preview for commit 9957f67 at: https://699af9e8cacbf11e7039175d--layer5.netlify.app |
|
My request for root causing is being ignored. |
|
@Rajesh-Nagarajan-11 you should’ve had this figured out. |
Description
This PR fixes #
Notes for Reviewers
Signed commits